From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3255 invoked by alias); 30 Jan 2015 18:55:39 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3209 invoked by uid 89); 30 Jan 2015 18:55:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg20.ericsson.net Received: from usevmg20.ericsson.net (HELO usevmg20.ericsson.net) (198.24.6.45) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 30 Jan 2015 18:55:36 +0000 Received: from EUSAAHC002.ericsson.se (Unknown_Domain [147.117.188.78]) by usevmg20.ericsson.net (Symantec Mail Security) with SMTP id 29.76.03307.2A08BC45; Fri, 30 Jan 2015 14:01:22 +0100 (CET) Received: from [142.133.110.232] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.80) with Microsoft SMTP Server id 14.3.195.1; Fri, 30 Jan 2015 13:55:33 -0500 Message-ID: <54CBD3A5.3010709@ericsson.com> Date: Fri, 30 Jan 2015 20:17:00 -0000 From: Simon Marchi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Joel Brobecker CC: Subject: Re: [PATCH] Free results of varobj_get_type and type_to_string References: <1422383618-8215-1-git-send-email-simon.marchi@ericsson.com> <20150129051126.GD5193@adacore.com> <54CA58D3.2000201@ericsson.com> <20150130090321.GP5193@adacore.com> In-Reply-To: <20150130090321.GP5193@adacore.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00800.txt.bz2 On 15-01-30 04:03 AM, Joel Brobecker wrote: >>>> gdb/ChangeLog: >>>> >>>> * mi/mi-cmd-var.c (mi_cmd_var_info_type): Free result of >>>> varobj_get_type. >>>> (varobj_update_one): Same. >>>> * varobj.c (update_type_if_necessary): Free curr_type_str and >>>> new_type_str. >>>> (varobj_get_type): Specify in comment that the result needs to be >>>> freed by the caller. > > Thank you. This looks good to me, so go ahead and push! Pushed, thanks!