From: Simon Marchi <simon.marchi@ericsson.com>
To: Joel Brobecker <brobecker@adacore.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH 3/6] Set varobj->path_expr in varobj_get_path_expr
Date: Fri, 30 Jan 2015 22:58:00 -0000 [thread overview]
Message-ID: <54CBDF81.5090702@ericsson.com> (raw)
In-Reply-To: <20150130033953.GO5193@adacore.com>
On 15-01-29 10:39 PM, Joel Brobecker wrote:
>> It seems like different languages are doing this differently (e.g.
>> C and Ada). For C, var->path_expr is set inside c_path_expr_of_child.
>> The next time the value is requested, is it therefore not recomputed.
>> Ada does not set this field, but just returns the value. Since the field
>> is never set, the value is recomputed every time it is requested.
>>
>> This patch makes it so that path_expr_of_child's only job is to compute
>> the path expression, not save/cache the value. The field is set by the
>> varobj common code.
>
> Nice little cleanup, IMO. Thanks for doing it.
>
>> gdb/ChangeLog:
>>
>> * varobj.c (varobj_get_path_expr): Set var->path_expr.
>> * c-varobj.c (c_path_expr_of_child): Set local var instead of
>> child->path_expr.
>> (cplus_path_expr_of_child): Same.
>
> LGTM. Thank you!
Pushed, thanks!
next prev parent reply other threads:[~2015-01-30 19:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 19:29 [PATCH 1/6] Free results of varobj_get_expression Simon Marchi
2015-01-30 1:56 ` [PATCH 3/6] Set varobj->path_expr in varobj_get_path_expr Simon Marchi
2015-01-30 18:55 ` Joel Brobecker
2015-01-30 22:58 ` Simon Marchi [this message]
2015-01-30 3:13 ` [PATCH 2/6] Mention which return values need to be freed in lang_varobj_ops Simon Marchi
2015-01-30 8:19 ` Joel Brobecker
2015-01-30 20:10 ` Simon Marchi
2015-01-31 20:06 ` Joel Brobecker
2015-02-02 18:18 ` Simon Marchi
2015-01-30 3:28 ` [PATCH 6/6] Fix varobj_delete comment Simon Marchi
2015-01-30 17:04 ` Joel Brobecker
2015-01-31 3:20 ` Simon Marchi
2015-01-30 3:33 ` [PATCH 5/6] Mention that create_child takes ownership of the allocated name Simon Marchi
2015-01-30 16:41 ` Joel Brobecker
2015-01-31 1:14 ` Simon Marchi
2015-01-30 3:35 ` [PATCH 4/6] Constify some parameters in the varobj code Simon Marchi
2015-01-30 9:03 ` Joel Brobecker
2015-01-30 22:59 ` Simon Marchi
2015-02-03 16:55 ` Pedro Alves
2015-02-03 18:07 ` Simon Marchi
2015-01-30 3:40 ` [PATCH 1/6] Free results of varobj_get_expression Joel Brobecker
2015-01-30 22:57 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54CBDF81.5090702@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).