Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().

[Chen Gang S <gang.chen@sunrus.com.cn>]

On 02/03/2015 10:50 AM, Joel Brobecker wrote:
> Chen,
> 
>>>> 2014-01-31  Chen Gang <gang.chen.5i5j@gmail.com>
>>>>
>>
>> Oh, sorry, the ChangeLog should use 2015-01-31 instead of 2014-01-31 for
>> the all related 4 patches. I shall send patch v2 for them.
> 
> One important thing to watch out for: I think you may not have realized
> that you pushed all 3 patches, whereas only the last one was approved.
> So, the first two ones weren't expected to be pushed yet. If you need
> help with git on how to push just the patches you want, let us know.
> One way, for instance, is to work in a separate branch, and then
> cherry-pick on master the patches only at the time where you want
> to push them. That's what I do, and prevents this kind of accident
> from happening.
> 

OK, thanks. I shall notice about it next time.

> In the meantime, since the patches have been pushed, I reviewed them
> and they look good to me. So no need to revert. Normally, those are
> reviewed by the sim maintainer, so he may have additional comments.
> 

OK, thanks.


-- 
Open, share, and attitude like air, water, and life which God blessed.