From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15808 invoked by alias); 3 Feb 2015 09:58:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15788 invoked by uid 89); 3 Feb 2015 09:58:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: out1134-218.mail.aliyun.com Received: from out1134-218.mail.aliyun.com (HELO out1134-218.mail.aliyun.com) (42.120.134.218) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Feb 2015 09:58:24 +0000 X-Alimail-AntiSpam:AC=CONTINUE;BC=0.08175155|-1;FP=0|0|0|0|0|-1|-1|-1;HT=r41f05017;MF=gang.chen@sunrus.com.cn;PH=DS;RN=2;RT=2;SR=0; Received: from 192.168.1.104(mailfrom:gang.chen@sunrus.com.cn ip:223.72.65.44) by smtp.aliyun-inc.com(10.147.11.251); Tue, 03 Feb 2015 17:58:18 +0800 Message-ID: <54D09BBD.6090600@sunrus.com.cn> Date: Tue, 03 Feb 2015 09:58:00 -0000 From: Chen Gang S User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: Joel Brobecker CC: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv(). References: <54CC0E99.1070501@sunrus.com.cn> <54CC2C8E.4090308@eagerm.com> <54CFD3F5.5080508@sunrus.com.cn> <20150203025001.GJ4525@adacore.com> In-Reply-To: <20150203025001.GJ4525@adacore.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00047.txt.bz2 On 02/03/2015 10:50 AM, Joel Brobecker wrote: > Chen, > >>>> 2014-01-31 Chen Gang >>>> >> >> Oh, sorry, the ChangeLog should use 2015-01-31 instead of 2014-01-31 for >> the all related 4 patches. I shall send patch v2 for them. > > One important thing to watch out for: I think you may not have realized > that you pushed all 3 patches, whereas only the last one was approved. > So, the first two ones weren't expected to be pushed yet. If you need > help with git on how to push just the patches you want, let us know. > One way, for instance, is to work in a separate branch, and then > cherry-pick on master the patches only at the time where you want > to push them. That's what I do, and prevents this kind of accident > from happening. > OK, thanks. I shall notice about it next time. > In the meantime, since the patches have been pushed, I reviewed them > and they look good to me. So no need to revert. Normally, those are > reviewed by the sim maintainer, so he may have additional comments. > OK, thanks. -- Open, share, and attitude like air, water, and life which God blessed.