From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31860 invoked by alias); 4 Feb 2015 18:18:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31851 invoked by uid 89); 4 Feb 2015 18:18:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Feb 2015 18:18:05 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t14IHvvD025390 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 4 Feb 2015 13:17:58 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t14IHtEd007384; Wed, 4 Feb 2015 13:17:56 -0500 Message-ID: <54D26253.8070800@redhat.com> Date: Wed, 04 Feb 2015 18:18:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Alex Velenko , Patrick Palka CC: "gdb-patches@sourceware.org" Subject: Re: [PATCH 3/3] Simplify event-loop core, remove two-step event processing References: <1422292759-22307-1-git-send-email-palves@redhat.com> <1422292759-22307-4-git-send-email-palves@redhat.com> <54D25832.1010007@arm.com> In-Reply-To: <54D25832.1010007@arm.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit X-SW-Source: 2015-02/txt/msg00095.txt.bz2 On 02/04/2015 06:34 PM, Alex Velenko wrote: > On 03/02/15 22:48, Patrick Palka wrote: >> This patch causes a build failure when compiling GDB with GCC 4.9: >> >> /home/patrick/code/binutils-gdb/gdb/event-loop.c: In function >> ‘gdb_do_one_event’: >> /home/patrick/code/binutils-gdb/gdb/event-loop.c:296:10: error: ‘res’ >> may be used uninitialized in this function >> [-Werror=maybe-uninitialized] >> if (res > 0) >> ^ >> > > Hi, > Event-loop.c "gdb_do_one_event" function did not initialize variable "res". > This caused gdb_binutils to fail building. This patch fixes it. Thanks! However, this fixed it for me: https://sourceware.org/ml/gdb-patches/2015-02/msg00075.html Can you make sure you have that in your tree? Thanks, Pedro Alves