From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8797 invoked by alias); 4 Feb 2015 18:58:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8775 invoked by uid 89); 4 Feb 2015 18:58:23 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 04 Feb 2015 18:58:21 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t14IwKF3018601 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Wed, 4 Feb 2015 13:58:20 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t14IwIYc027990; Wed, 4 Feb 2015 13:58:19 -0500 Message-ID: <54D26BCA.2000505@redhat.com> Date: Wed, 04 Feb 2015 18:58:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Jan Kratochvil , gdb-patches@sourceware.org Subject: Re: [patch] Fix Python 3 build error on 32-bit hosts References: <20150204174311.GA24375@host1.jankratochvil.net> In-Reply-To: <20150204174311.GA24375@host1.jankratochvil.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00098.txt.bz2 On 02/04/2015 06:43 PM, Jan Kratochvil wrote: > A question is whether the autoconf test isn't an overkill. I agree with Paul here. I think checking Python version is sufficient. One could use > instead just: > #if PYTHON_ABI_VERSION >= 3 This https://docs.python.org/3/c-api/object.html#PyObject_Hash and a quick web search for Py_hash_t seems to indicate that we should check for Python >=3.2, not just 3. > Also one could use that #if either just at the valpy_hash() definition or one > could provide Py_hash_t in gdb/defs.h or one could provide some GDB_Py_hash_t > in gdb/defs.h. I'd be fine with providing a fallback Py_hash_t in python/python-internal.h, where we already do a series of fallback definitions and fixes for older Python, such as e.g. Py_ssize_t. Thanks, Pedro Alves