From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7259 invoked by alias); 10 Feb 2015 17:27:10 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 7239 invoked by uid 89); 10 Feb 2015 17:27:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 10 Feb 2015 17:27:08 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t1AHR6vv020004 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 10 Feb 2015 12:27:06 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t1AHR4BW015836; Tue, 10 Feb 2015 12:27:05 -0500 Message-ID: <54DA3F68.4040107@redhat.com> Date: Tue, 10 Feb 2015 17:27:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix a pair of screen-resizing issues in TUI References: <1420861759-10700-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1420861759-10700-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00267.txt.bz2 On 01/10/2015 03:49 AM, Patrick Palka wrote: > This patch fixes a pair of TUI issues related to screen resizing: > > 1. In tui_handle_resize_during_io(), when the TUI screen gets resized, > we fail to update GDB's idea about the height of the output window. > > You can see this bug by doing: > > a. Enter TUI mode. > b. "show height" > c. Resize the terminal. > d. "show height" > > And observe that despite resizing the terminal, the reported height > remains unchanged. Note that a similar issue exists in the CLI. > > The fix for this is simple: call tui_update_gdb_sizes() after performing > a resize, so that the "height" variable remains consistent with the > height of TUI's output window. > > 2. In tui_enable(), the call to tui_update_gdb_sizes() may clobber > readline's idea of the actual screen dimensions, and a subsequent > pending resize will use bogus terminal dimensions. > > You can see this bug by doing: > > a. Enter TUI mode. > b. Exit TUI mode. > c. Resize the terminal. > d. Enter TUI mode. > e. Press a key to resize the screen. > > And observe that the terminal gets incorrectly resized to the wrong > dimensions. To fix this issue, we should oppurtunistically resize the > screen in tui_enable(). That way we eliminate the possibility of a > pending resize triggering right after we call tui_update_gdb_sizes(). > > gdb/ChangeLog: > > * tui/tui-io.c (tui_handle_resize_during_io): Call > tui_update_gdb_sizes() after resizing the screen. > * tui/tui.c (tui_enable): Resize the terminal before > calling tui_update_gdb_sizes(). OK. Thanks! -- Pedro Alves