From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12088 invoked by alias); 11 Feb 2015 17:28:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 12068 invoked by uid 89); 11 Feb 2015 17:28:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: elasmtp-scoter.atl.sa.earthlink.net Received: from elasmtp-scoter.atl.sa.earthlink.net (HELO elasmtp-scoter.atl.sa.earthlink.net) (209.86.89.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Feb 2015 17:28:28 +0000 Received: from [68.104.56.205] (helo=macbook2.local) by elasmtp-scoter.atl.sa.earthlink.net with esmtpa (Exim 4.67) (envelope-from ) id 1YLb5N-0004j0-LT; Wed, 11 Feb 2015 12:28:25 -0500 Message-ID: <54DB9139.7000206@earthlink.net> Date: Wed, 11 Feb 2015 17:28:00 -0000 From: Stan Shebs User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: David Taylor CC: Joel Brobecker , "gdb-patches@sourceware.org" Subject: Re: two agent expression nits (one line each) References: <14583.1410458050@usendtaylorx2l> <547E24E5.8050908@earthlink.net> <20141213134428.GF5457@adacore.com> <23074.1418658035@usendtaylorx2l> <20141220171955.GG12884@adacore.com> <18513.1423000644@usendtaylorx2l> In-Reply-To: <18513.1423000644@usendtaylorx2l> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-ELNK-Trace: ae6f8838ff913eba0cc1426638a40ef67e972de0d01da9400dbcabdc4eb2fbb009fb048f99c7858d350badd9bab72f9c350badd9bab72f9c350badd9bab72f9c X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00316.txt.bz2 On 2/3/15 1:57 PM, David Taylor wrote: > Joel Brobecker wrote: > >> Hi David, > > [...] > >> Since you understand what should be done, would you mind sending >> a patch in for Stan to review? >> >> -- >> Joel > > Joel, > > Sorry for the delay. Here's the patch. Also, I haven't forgotten that > I owe you an updated patch for bad structure offsets. And I have some > others in the queue to finish up and post, as well. These changes are both fine as posted, thanks! And I agree that they would be good candidates for 7.9 branch as well. Stan > > Stan, > > Here's the ChangeLog entries: > > gdb: > > 2015-02-03 David Taylor > > * common/ax.def (setv): Fix consumed entry in setv DEFOP. > > gdb/doc: > > 2015-02-03 David Taylor > > * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > > > and patch, as requested by Joel: > > diff --git a/gdb/ChangeLog b/gdb/ChangeLog > index 351ccdd..0118d7d 100644 > --- a/gdb/ChangeLog > +++ b/gdb/ChangeLog > @@ -1,3 +1,7 @@ > +2015-02-03 David Taylor > + > + * common/ax.def (setv): Fix consumed entry in setv DEFOP. > + > 2015-02-02 Joel Brobecker > > * dwarf2loc.c (dwarf2_evaluate_property): Add i18n marker. > diff --git a/gdb/common/ax.def b/gdb/common/ax.def > index 8b27725..27c97cc 100644 > --- a/gdb/common/ax.def > +++ b/gdb/common/ax.def > @@ -83,7 +83,7 @@ DEFOP (pop, 0, 0, 1, 0, 0x29) > DEFOP (zero_ext, 1, 0, 1, 1, 0x2a) > DEFOP (swap, 0, 0, 2, 2, 0x2b) > DEFOP (getv, 2, 0, 0, 1, 0x2c) > -DEFOP (setv, 2, 0, 0, 1, 0x2d) > +DEFOP (setv, 2, 0, 1, 1, 0x2d) > DEFOP (tracev, 2, 0, 0, 1, 0x2e) > DEFOP (tracenz, 0, 0, 2, 0, 0x2f) > DEFOP (trace16, 2, 0, 1, 1, 0x30) > diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog > index 9c12d9a..34fee48 100644 > --- a/gdb/doc/ChangeLog > +++ b/gdb/doc/ChangeLog > @@ -1,3 +1,7 @@ > +2015-02-03 David Taylor > + > + * agentexpr.texi (Bytecode Descriptions): Fix summary line for setv. > + > 2015-01-31 Gary Benson > Doug Evans > > diff --git a/gdb/doc/agentexpr.texi b/gdb/doc/agentexpr.texi > index 788de1c..297cd5e 100644 > --- a/gdb/doc/agentexpr.texi > +++ b/gdb/doc/agentexpr.texi > @@ -461,7 +461,7 @@ alignment within the bytecode stream; thus, on machines where fetching a > 16-bit on an unaligned address raises an exception, you should fetch the > register number one byte at a time. > > -@item @code{setv} (0x2d) @var{n}: @result{} @var{v} > +@item @code{setv} (0x2d) @var{n}: @var{v} @result{} @var{v} > Set trace state variable number @var{n} to the value found on the top > of the stack. The stack is unchanged, so that the value is readily > available if the assignment is part of a larger expression. The >