From: Chen Gang S <gang.chen@sunrus.com.cn>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv().
Date: Thu, 19 Feb 2015 00:34:00 -0000 [thread overview]
Message-ID: <54E53156.2060709@sunrus.com.cn> (raw)
In-Reply-To: <20150218002200.GQ544@vapier>
On 2/18/15 08:22, Mike Frysinger wrote:
> On 18 Feb 2015 07:18, Chen Gang S wrote:
>> On 2/17/15 18:34, Mike Frysinger wrote:
>>> On 31 Jan 2015 07:07, Chen Gang S wrote:
>>>> --- a/sim/ChangeLog
>>>> +++ b/sim/ChangeLog
>>>> @@ -1,5 +1,10 @@
>>>> 2014-01-31 Chen Gang <gang.chen.5i5j@gmail.com>
>>>>
>>>> + * microblaze/interp.c (sim_do_command): Call freeargv() before
>>>> + return.
>>>
>>> this should be in sim/microblaze/ChangeLog instead. it looks like your last 4
>>> entries in sim/ChangeLog need to get relocated. please do so.
>>>
>>
>> Oh, really, I shall change the related comments.
>>
>>> while you're there, you should also fix your gentmap.c entry in
>>> sim/common/ChangeLog -- only one space after the * is used.
>>>
>>
>> Oh, really, I shall change the related comments.
>>
>>> as for the actual code, lgtm. thanks for fixing up the various error paths.
>>
>> That what I should do, since I focus on binutils and gdb. :-)
>>
>> And excuse me, I am not quite familiar with the related working flow.
>> Can I send 1 patch to fix the 2 comments, and "git push" it after it is
>> reviewed?.
>
> generally the sim tree follows the gdb/binutils procedure. i.e. people should
> post patches to the list and wait for approval from a relevant maintainer. we
> don't generally get strict with the rules as long as you have good intentions
> and aren't breaking things (like compile failures) :). so don't get too worried
> and feel free to ask as people don't mind helping guide newbies.
> -mike
>
OK, thanks. I shall send one patch for the 2 comments, next.
Thanks.
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
next prev parent reply other threads:[~2015-02-19 0:34 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-31 11:56 Chen Gang S
2015-01-31 18:46 ` Michael Eager
2015-02-02 19:38 ` Chen Gang S
2015-02-03 2:50 ` Joel Brobecker
2015-02-03 9:58 ` Chen Gang S
2015-02-17 10:34 ` Mike Frysinger
2015-02-17 23:10 ` Chen Gang S
2015-02-18 0:22 ` Mike Frysinger
2015-02-19 0:34 ` Chen Gang S [this message]
2015-02-19 15:53 ` Michael Eager
-- strict thread matches above, loose matches on Subject: below --
2015-01-31 8:59 Chen Gang S
2015-01-28 15:53 Chen Gang S
2015-01-28 20:43 ` Michael Eager
2015-01-29 4:53 ` Chen Gang S
2015-01-29 5:01 ` Michael Eager
2015-01-29 5:11 ` Chen Gang S
2015-02-17 10:36 ` Mike Frysinger
2015-01-29 7:03 ` Joel Brobecker
2015-01-29 7:28 ` Chen Gang S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54E53156.2060709@sunrus.com.cn \
--to=gang.chen@sunrus.com.cn \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).