From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8775 invoked by alias); 19 Feb 2015 00:34:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8753 invoked by uid 89); 19 Feb 2015 00:34:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham version=3.3.2 X-HELO: out1134-179.mail.aliyun.com Received: from out1134-179.mail.aliyun.com (HELO out1134-179.mail.aliyun.com) (42.120.134.179) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Feb 2015 00:34:09 +0000 X-Alimail-AntiSpam:AC=CONTINUE;BC=0.07527086|-1;FP=0|0|0|0|0|-1|-1|-1;HT=r46d02012;MF=gang.chen@sunrus.com.cn;PH=DS;RN=1;RT=1;SR=0; Received: from ShengShiZhuChengdeMacBook-Pro.local(mailfrom:gang.chen@sunrus.com.cn ip:223.72.65.10) by smtp.aliyun-inc.com(10.194.100.23); Thu, 19 Feb 2015 08:34:05 +0800 Message-ID: <54E53156.2060709@sunrus.com.cn> Date: Thu, 19 Feb 2015 00:34:00 -0000 From: Chen Gang S User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv(). References: <54CC0E99.1070501@sunrus.com.cn> <20150217103425.GB544@vapier> <54E3CC2D.40402@sunrus.com.cn> <20150218002200.GQ544@vapier> In-Reply-To: <20150218002200.GQ544@vapier> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-02/txt/msg00508.txt.bz2 On 2/18/15 08:22, Mike Frysinger wrote: > On 18 Feb 2015 07:18, Chen Gang S wrote: >> On 2/17/15 18:34, Mike Frysinger wrote: >>> On 31 Jan 2015 07:07, Chen Gang S wrote: >>>> --- a/sim/ChangeLog >>>> +++ b/sim/ChangeLog >>>> @@ -1,5 +1,10 @@ >>>> 2014-01-31 Chen Gang >>>> >>>> + * microblaze/interp.c (sim_do_command): Call freeargv() before >>>> + return. >>> >>> this should be in sim/microblaze/ChangeLog instead. it looks like your last 4 >>> entries in sim/ChangeLog need to get relocated. please do so. >>> >> >> Oh, really, I shall change the related comments. >> >>> while you're there, you should also fix your gentmap.c entry in >>> sim/common/ChangeLog -- only one space after the * is used. >>> >> >> Oh, really, I shall change the related comments. >> >>> as for the actual code, lgtm. thanks for fixing up the various error paths. >> >> That what I should do, since I focus on binutils and gdb. :-) >> >> And excuse me, I am not quite familiar with the related working flow. >> Can I send 1 patch to fix the 2 comments, and "git push" it after it is >> reviewed?. > > generally the sim tree follows the gdb/binutils procedure. i.e. people should > post patches to the list and wait for approval from a relevant maintainer. we > don't generally get strict with the rules as long as you have good intentions > and aren't breaking things (like compile failures) :). so don't get too worried > and feel free to ask as people don't mind helping guide newbies. > -mike > OK, thanks. I shall send one patch for the 2 comments, next. Thanks. -- Chen Gang Open, share, and attitude like air, water, and life which God blessed