From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31375 invoked by alias); 19 Feb 2015 15:53:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 31364 invoked by uid 89); 19 Feb 2015 15:53:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-HELO: homiemail-a42.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a42.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Feb 2015 15:53:17 +0000 Received: from homiemail-a42.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a42.g.dreamhost.com (Postfix) with ESMTP id 1ECD368C05F; Thu, 19 Feb 2015 07:53:16 -0800 (PST) Received: from redwood.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a42.g.dreamhost.com (Postfix) with ESMTPSA id 4441C68C05B; Thu, 19 Feb 2015 07:53:04 -0800 (PST) Message-ID: <54E606DF.3080605@eagerm.com> Date: Thu, 19 Feb 2015 15:53:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Chen Gang S , gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Be sure of calling freeargv() after successfully call buildargv(). References: <54CC0E99.1070501@sunrus.com.cn> <20150217103425.GB544@vapier> <54E3CC2D.40402@sunrus.com.cn> <20150218002200.GQ544@vapier> <54E53156.2060709@sunrus.com.cn> In-Reply-To: <54E53156.2060709@sunrus.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00539.txt.bz2 On 02/18/15 16:41, Chen Gang S wrote: > On 2/18/15 08:22, Mike Frysinger wrote: >> On 18 Feb 2015 07:18, Chen Gang S wrote: >>> On 2/17/15 18:34, Mike Frysinger wrote: >>>> On 31 Jan 2015 07:07, Chen Gang S wrote: >>>>> --- a/sim/ChangeLog >>>>> +++ b/sim/ChangeLog >>>>> @@ -1,5 +1,10 @@ >>>>> 2014-01-31 Chen Gang >>>>> >>>>> + * microblaze/interp.c (sim_do_command): Call freeargv() before >>>>> + return. >>>> >>>> this should be in sim/microblaze/ChangeLog instead. it looks like your last 4 >>>> entries in sim/ChangeLog need to get relocated. please do so. >>>> >>> >>> Oh, really, I shall change the related comments. >>> >>>> while you're there, you should also fix your gentmap.c entry in >>>> sim/common/ChangeLog -- only one space after the * is used. >>>> >>> >>> Oh, really, I shall change the related comments. >>> >>>> as for the actual code, lgtm. thanks for fixing up the various error paths. >>> >>> That what I should do, since I focus on binutils and gdb. :-) >>> >>> And excuse me, I am not quite familiar with the related working flow. >>> Can I send 1 patch to fix the 2 comments, and "git push" it after it is >>> reviewed?. >> >> generally the sim tree follows the gdb/binutils procedure. i.e. people should >> post patches to the list and wait for approval from a relevant maintainer. we >> don't generally get strict with the rules as long as you have good intentions >> and aren't breaking things (like compile failures) :). so don't get too worried >> and feel free to ask as people don't mind helping guide newbies. >> -mike >> > > OK, thanks. I shall send one patch for the 2 comments, next. If all you are changing is correcting the ChangeLog as indicated, we can relax the normal procedure. Please just check in fixes. -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077