[PATCH] sim/ChangeLog: Correct the related items' position and format.

[PATCH] sim/ChangeLog: Correct the related items' position and format.

[Chen Gang S]

2015-02-19  Chen Gang  <gang.chen.5i5j@gmail.com>

	* ChangeLog: Move sub-modules related items to their own
	ChangeLogs.
	* common/ChangeLog: Remove the incorrect white space.
---
 sim/ChangeLog            | 20 +++-----------------
 sim/common/ChangeLog     | 11 ++++++++++-
 sim/mcore/ChangeLog      |  4 ++++
 sim/microblaze/ChangeLog |  9 +++++++++
 4 files changed, 26 insertions(+), 18 deletions(-)

diff --git a/sim/ChangeLog b/sim/ChangeLog
index a891ce5..53fa7ba 100644
--- a/sim/ChangeLog
+++ b/sim/ChangeLog
@@ -1,21 +1,7 @@
-2015-02-02  Chen Gang <gang.chen.5i5j@gmail.com>
+2015-02-19  Chen Gang  <gang.chen.5i5j@gmail.com>
 
-	* microblaze/interp.c (sim_do_command): Call freeargv() before
-	return.
-
-2015-02-02  Chen Gang <gang.chen.5i5j@gmail.com>
-
-	* mcore/interp.c (sim_do_command): Call freeargv() before return.
-
-2015-02-02  Chen Gang <gang.chen.5i5j@gmail.com>
-
-	* common/sim-options.c (sim_args_command): Call freeargv() when
-	failure occurs.
-
-2014-07-01  Chen Gang <gang.chen.5i5j@gmail.com>
-
-	* sim/microblaze/interp.c: Use long int format instead of int
-	format to avoid compiling warnings.
+	* ChangeLog: Move sub-modules related items to their own
+	ChangeLogs.
 
 2014-03-12  Nick Clifton  <nickc@redhat.com>
 
diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog
index 7acc03c..90de2a1 100644
--- a/sim/common/ChangeLog
+++ b/sim/common/ChangeLog
@@ -1,6 +1,15 @@
+2015-02-19  Chen Gang  <gang.chen.5i5j@gmail.com>
+
+	* ChangeLog: Remove the incorrect white space.
+
 2015-02-13  Chen Gang  <gang.chen.5i5j@gmail.com>
 
-	*  gentmap.c: Include "string.h".
+	* gentmap.c: Include "string.h".
+
+2015-02-02  Chen Gang  <gang.chen.5i5j@gmail.com>
+
+	* sim-options.c (sim_args_command): Call freeargv() when failure
+	occurs.
 
 2015-01-07  Joel Brobecker  <brobecker@adacore.com>
 
diff --git a/sim/mcore/ChangeLog b/sim/mcore/ChangeLog
index d108974..24f595e 100644
--- a/sim/mcore/ChangeLog
+++ b/sim/mcore/ChangeLog
@@ -2,6 +2,10 @@
 
 	* interp.c: Include "unistd.h".
 
+2015-02-02  Chen Gang  <gang.chen.5i5j@gmail.com>
+
+	* interp.c (sim_do_command): Call freeargv() before return.
+
 2014-08-19  Alan Modra  <amodra@gmail.com>
 
 	* configure: Regenerate.
diff --git a/sim/microblaze/ChangeLog b/sim/microblaze/ChangeLog
index bed555f..a805ec2 100644
--- a/sim/microblaze/ChangeLog
+++ b/sim/microblaze/ChangeLog
@@ -1,3 +1,12 @@
+
+2015-02-02  Chen Gang  <gang.chen.5i5j@gmail.com>
+
+	* interp.c (sim_do_command): Call freeargv() before return.
+
+2014-07-01  Chen Gang  <gang.chen.5i5j@gmail.com>
+
+	* interp.c: Use long int format instead of int format.
+
 2014-08-19  Alan Modra  <amodra@gmail.com>
 
 	* configure: Regenerate.
-- 
1.9.3

Re: [PATCH] sim/ChangeLog: Correct the related items' position and format.

[Mike Frysinger]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

On 19 Feb 2015 09:06, Chen Gang S wrote:
> --- a/sim/ChangeLog
> +++ b/sim/ChangeLog
>
> +	* ChangeLog: Move sub-modules related items to their own
> +	ChangeLogs.

heh, so meta.  i'm not sure we generally do this ... does anyone else have input 
here ?
-mike

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH] sim/ChangeLog: Correct the related items' position and format.

[Pedro Alves]

On 02/19/2015 02:22 AM, Mike Frysinger wrote:
> On 19 Feb 2015 09:06, Chen Gang S wrote:
>> --- a/sim/ChangeLog
>> +++ b/sim/ChangeLog
>>
>> +	* ChangeLog: Move sub-modules related items to their own
>> +	ChangeLogs.
> 
> heh, so meta.  i'm not sure we generally do this ... does anyone else have input 
> here ?

Yeah.  ChangeLog changes don't get mentioned in ChangeLog.

Thanks,
Pedro Alves

Re: [PATCH] sim/ChangeLog: Correct the related items' position and format.

[Chen Gang S]

On 2/19/15 19:01, Pedro Alves wrote:
> On 02/19/2015 02:22 AM, Mike Frysinger wrote:
>> On 19 Feb 2015 09:06, Chen Gang S wrote:
>>> --- a/sim/ChangeLog
>>> +++ b/sim/ChangeLog
>>>
>>> +	* ChangeLog: Move sub-modules related items to their own
>>> +	ChangeLogs.
>>
>> heh, so meta.  i'm not sure we generally do this ... does anyone else have input 
>> here ?
> 
> Yeah.  ChangeLog changes don't get mentioned in ChangeLog.
> 

OK, thanks, I guess your meaning is "If we only change the ChangeLog
contents, we don't need additional ChangeLog comment for it.". e.g. in
our case, we don't need the contents below (they need to be removed when
I send patch v2):

  --- a/sim/ChangeLog
  +++ b/sim/ChangeLog
  
  +2015-02-19  Chen Gang  <gang.chen.5i5j@gmail.com>
  +
  +	* ChangeLog: Move sub-modules related items to their own
  +	ChangeLogs.
  
  
  --- a/sim/common/ChangeLog
  +++ b/sim/common/ChangeLog
  
  +2015-02-19  Chen Gang  <gang.chen.5i5j@gmail.com>
  +
  +	* ChangeLog: Remove the incorrect white space.

If no additional replies within 2 days (2015-02-21), I shall send patch
v2 for it.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] sim/ChangeLog: Correct the related items' position and format.

[Pedro Alves]

On 02/19/2015 11:48 AM, Chen Gang S wrote:
> On 2/19/15 19:01, Pedro Alves wrote:
>> On 02/19/2015 02:22 AM, Mike Frysinger wrote:
>>> On 19 Feb 2015 09:06, Chen Gang S wrote:
>>>> --- a/sim/ChangeLog
>>>> +++ b/sim/ChangeLog
>>>>
>>>> +	* ChangeLog: Move sub-modules related items to their own
>>>> +	ChangeLogs.
>>>
>>> heh, so meta.  i'm not sure we generally do this ... does anyone else have input 
>>> here ?
>>
>> Yeah.  ChangeLog changes don't get mentioned in ChangeLog.
>>
> 
> OK, thanks, I guess your meaning is "If we only change the ChangeLog
> contents, we don't need additional ChangeLog comment for it.". e.g. in
> our case, we don't need the contents below (they need to be removed when
> I send patch v2):

Right.  To be super clear, drop the "only":

  "If we change the ChangeLog contents, we don't need additional ChangeLog comment for it."

Thanks,
Pedro Alves

Re: [PATCH] sim/ChangeLog: Correct the related items' position and format.

[Chen Gang S]

On 2/19/15 19:48, Pedro Alves wrote:
> On 02/19/2015 11:48 AM, Chen Gang S wrote:
>> On 2/19/15 19:01, Pedro Alves wrote:
>>> On 02/19/2015 02:22 AM, Mike Frysinger wrote:
>>>> On 19 Feb 2015 09:06, Chen Gang S wrote:
>>>>> --- a/sim/ChangeLog
>>>>> +++ b/sim/ChangeLog
>>>>>
>>>>> +	* ChangeLog: Move sub-modules related items to their own
>>>>> +	ChangeLogs.
>>>>
>>>> heh, so meta.  i'm not sure we generally do this ... does anyone else have input 
>>>> here ?
>>>
>>> Yeah.  ChangeLog changes don't get mentioned in ChangeLog.
>>>
>>
>> OK, thanks, I guess your meaning is "If we only change the ChangeLog
>> contents, we don't need additional ChangeLog comment for it.". e.g. in
>> our case, we don't need the contents below (they need to be removed when
>> I send patch v2):
> 
> Right.  To be super clear, drop the "only":
> 
>   "If we change the ChangeLog contents, we don't need additional ChangeLog comment for it."
> 

OK, thanks. What you said sounds a little more preciser.

Thanks.
-- 
Chen Gang

Open, share, and attitude like air, water, and life which God blessed

Re: [PATCH] sim/ChangeLog: Correct the related items' position and format.

[Michael Eager]

On 02/18/15 17:06, Chen Gang S wrote:
> 2015-02-19  Chen Gang  <gang.chen.5i5j@gmail.com>
>
> 	* ChangeLog: Move sub-modules related items to their own
> 	ChangeLogs.
> 	* common/ChangeLog: Remove the incorrect white space.

OK.


-- 
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077