From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64939 invoked by alias); 27 Feb 2015 12:12:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 64922 invoked by uid 89); 27 Feb 2015 12:12:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=2.3 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KAM_FROM_URIBL_PCCC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 X-HELO: mail-pa0-f44.google.com Received: from mail-pa0-f44.google.com (HELO mail-pa0-f44.google.com) (209.85.220.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-GCM-SHA256 encrypted) ESMTPS; Fri, 27 Feb 2015 12:12:34 +0000 Received: by paceu11 with SMTP id eu11so22292375pac.7 for ; Fri, 27 Feb 2015 04:12:32 -0800 (PST) X-Received: by 10.70.43.238 with SMTP id z14mr22966212pdl.113.1425039152513; Fri, 27 Feb 2015 04:12:32 -0800 (PST) Received: from [127.0.0.1] (gcc1-power7.osuosl.org. [140.211.15.137]) by mx.google.com with ESMTPSA id ua7sm3866906pab.37.2015.02.27.04.12.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 27 Feb 2015 04:12:32 -0800 (PST) Message-ID: <54F05F2C.5020007@gmail.com> Date: Fri, 27 Feb 2015 12:12:00 -0000 From: Yao Qi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Pedro Alves CC: gdb-patches@sourceware.org Subject: Re: [PATCH 5/6] testsuite: Introduce $inferior_spawn_id References: <1424699660-11727-1-git-send-email-palves@redhat.com> <1424699660-11727-6-git-send-email-palves@redhat.com> <867fv7xodw.fsf@gmail.com> <54F04A2B.5@redhat.com> <54F04E16.2070704@redhat.com> In-Reply-To: <54F04E16.2070704@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-02/txt/msg00813.txt.bz2 Hi Pedro, This patch is fine by me. On 27/02/15 10:59, Pedro Alves wrote: > + /* Always force this for Windows testing. To a native Windows > + program running under under a Cygwin shell/ssh, stdin is really a Double "under". > + Windows pipe, thus not a tty and its outputs ends up fully > + buffered. */ > +#ifndef __MINGW32__ > + if (!isatty (fileno (stdin))) > +#endif Include unistd.h for isatty? -- Yao (齐尧)