From: Pedro Alves <palves@redhat.com>
To: Don Breazeal <donb@codesourcery.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v5 0/6] Remote fork events
Date: Mon, 02 Mar 2015 18:29:00 -0000 [thread overview]
Message-ID: <54F4ABFE.5020801@redhat.com> (raw)
In-Reply-To: <1424997977-13316-1-git-send-email-donb@codesourcery.com>
Thanks Don,
On a quick skim, this version is looking much better.
I'll apply this to my sandbox and take a deeper look.
Thanks,
Pedro Alves
On 02/27/2015 12:46 AM, Don Breazeal wrote:
> This is an update to the patch series implementing remote follow-fork.
> This update only implements fork and vfork events for extended remote,
> omitting exec events and 'target remote' for now.
>
> Changes from the previous version include:
> * Removed 'target remote' support, which is deferred for later.
> * Fixes per review comments, notably
> - issues with unpushing the target after detach or kill
> - reorganizing/renaming some things, both to match the
> native implementation better and for just plain better
> organization.
> - fixed and/or improved some of the event handling code.
> * Also added documentation to each individual patch, rather than
> saving it all for a subsequent 'documentation patch'.
>
> The new series includes six patches as follows:
>
> 1/6: Preparatory patch that implements qSupported support for fork events
> and associated mechanisms.
>
> 2/6: Implements functions to clone breakpoint lists in gdbserver.
>
> 3/6: Implements follow fork for 'fork' but not 'vfork', for
> extended-remote targets only.
>
> 4/6: Adds the architecture-specific pieces of follow-fork that allows
> hardware watchpoints to be inherited by a forked child.
> This patch was previously approved, although I have added a
> trivial change to gdb/NEWS in this patch.
>
> 5/6: Adds follow fork for 'vfork'.
>
> 6/6: Adds catchpoints for 'fork' and 'vfork', along with support for
> killing a process that has forked but has not been followed.
>
> TESTING:
> Testing was mostly done using x86_64 Ubuntu, with the exception of the
> architecture-specific patch, #4. There are a few anomalies that show
> up, but don't signify any problem.
>
> - Intermediate patches show failures due to the lack of features
> implemented in subsequent patches, like missing hardware watchpoint
> or catchpoint support.
>
> - Some vfork tests fail due to the lack of exec event support.
>
> - There are a couple of tests that show new failures that actually
> fail in the current mainline. Details of these are as follows:
>
> * when vfork events are enabled, gdb.base/disp-step-syscall.exp
> shows PASS => FAIL in .sum diffs. The test actually always
> fails. With native/master, we see
>
> stepi^M
> FAIL: gdb.base/disp-step-syscall.exp: vfork: stepi vfork insn
> (timeout)
>
> With remote and extended-remote/master, we see a bogus PASS result:
> stepi^M
> [Inferior 1 (process 9399) exited normally]^M
> (gdb) PASS: gdb.base/disp-step-syscall.exp: vfork: stepi vfork insn
>
> The criteria to pass that test are pretty lax:
> gdb_test "stepi" ".*" "stepi $syscall insn"
>
> * Similarly, once vfork events are enabled, gdb.base/watch-vfork.exp
> shows PASS => FAIL in .sum diffs. This test also always fails. With
> native/master, we see this:
>
> continue^M
> Continuing.^M
> FAIL: gdb.base/watch-vfork.exp: Watchpoint triggers after vfork
> (sw) (timeout)
>
> With extended-remote/master, we see this:
> continue
> Continuing.
> [Inferior 1 (process 18866) exited normally]
> (gdb) FAIL: gdb.base/watch-vfork.exp: Watchpoint triggers after
> vfork (sw) (the program exited)
>
> But once vfork events are enabled, we see:
> continue
> Continuing.
> Detaching from process 17405
> FAIL: gdb.base/watch-vfork.exp: Watchpoint triggers after vfork
> (sw) (timeout)
> which more-or-less matches the native/master behavior.
>
> Thanks,
> --Don
>
next prev parent reply other threads:[~2015-03-02 18:29 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201501252151.t0PLo3jE018308@mx0b-0013c101.pphosted.com>
2015-01-26 4:43 ` [PATCH v4 0/7] " Breazeal, Don
2015-02-06 20:02 ` Breazeal, Don
2015-02-27 0:46 ` [PATCH v5 0/6] " Don Breazeal
2015-02-27 0:46 ` [PATCH v5 01/06] Identify remote fork event support Don Breazeal
2015-02-27 0:47 ` [PATCH v5 03/06] Extended-remote Linux follow fork Don Breazeal
2015-02-27 0:47 ` [PATCH v5 05/06] Remote follow vfork Don Breazeal
2015-02-27 0:47 ` [PATCH v5 02/06] Clone remote breakpoints Don Breazeal
2015-02-27 0:47 ` [PATCH v5 04/06] Arch-specific remote follow fork Don Breazeal
2015-02-27 7:37 ` Eli Zaretskii
2015-02-27 0:48 ` [PATCH v5 06/06] Remote fork catch Don Breazeal
2015-03-02 18:29 ` Pedro Alves [this message]
2015-03-02 20:18 ` [PATCH] Tighten gdb.base/disp-step-syscall.exp (was: Re: [PATCH v5 0/6] Remote fork events) Pedro Alves
2015-03-03 6:20 ` [PATCH] Tighten gdb.base/disp-step-syscall.exp Breazeal, Don
2015-03-03 15:01 ` Pedro Alves
2015-03-17 21:18 ` Breazeal, Don
2015-03-18 19:37 ` Pedro Alves
2015-03-17 20:56 ` [PATCH v6 0/6] Remote fork events Don Breazeal
2015-03-17 20:56 ` [PATCH v6 1/6] Identify remote fork event support Don Breazeal
2015-03-24 10:57 ` Pedro Alves
2015-03-26 19:00 ` [PATCH v5 01/06] " Don Breazeal
2015-03-27 11:14 ` Pedro Alves
2015-03-17 20:57 ` [PATCH v6 3/6] Extended-remote Linux follow fork Don Breazeal
2015-03-24 12:17 ` Pedro Alves
2015-04-07 17:35 ` Pedro Alves
2015-03-17 20:57 ` [PATCH v6 2/6] Clone remote breakpoints Don Breazeal
2015-03-17 20:57 ` [PATCH v6 4/6] Arch-specific remote follow fork Don Breazeal
2015-03-17 20:58 ` [PATCH v6 6/6] Remote fork catch Don Breazeal
2015-03-24 12:47 ` Pedro Alves
2015-03-17 20:58 ` [PATCH v6 5/6] Remote follow vfork Don Breazeal
2015-03-24 12:28 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F4ABFE.5020801@redhat.com \
--to=palves@redhat.com \
--cc=donb@codesourcery.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).