From: Simon Marchi <simon.marchi@ericsson.com>
To: Pedro Alves <palves@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Accept all-stop alternative in mi_expect_interrupt
Date: Wed, 04 Mar 2015 22:58:00 -0000 [thread overview]
Message-ID: <54F78E0B.2070004@ericsson.com> (raw)
In-Reply-To: <54F781B2.70303@redhat.com>
On 03/04/2015 05:05 PM, Pedro Alves wrote:
> On 03/04/2015 09:44 PM, Simon Marchi wrote:
>
>> gdb/testsuite/lib/mi-support.exp | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp
>> index 20546f6..b8f6334 100644
>> --- a/gdb/testsuite/lib/mi-support.exp
>> +++ b/gdb/testsuite/lib/mi-support.exp
>> @@ -1195,14 +1195,14 @@ proc mi_expect_interrupt { test } {
>> set prompt_re "$mi_gdb_prompt$"
>> }
>>
>> - set r "reason=\"signal-received\",signal-name=\"0\",signal-meaning=\"Signal 0\""
>> -
>> + set r_nonstop "reason=\"signal-received\",signal-name=\"0\",signal-meaning=\"Signal 0\""
>> + set r_allstop "reason=\"signal-received\",signal-name=\"SIGINT\",signal-meaning=\"Interrupt\""
>
> Add:
>
> set r "(${r_nonstop}|${r_allstop})"
>
> and then you don't need this hunk below (and don't need to write the same thing twice):
Nice, done.
>> set any "\[^\n\]*"
>>
>> # A signal can land anywhere, just ignore the location
>> - verbose -log "mi_expect_interrupt: expecting: \\*stopped,${r}$any\r\n$prompt_re"
>> + verbose -log "mi_expect_interrupt: expecting: \\*stopped,(${r_nonstop}|${r_allstop})$any\r\n$prompt_re"
>> gdb_expect {
>> - -re "\\*stopped,${r}$any\r\n$prompt_re" {
>> + -re "\\*stopped,(${r_nonstop}|${r_allstop})$any\r\n$prompt_re" {
>> pass "$test"
>> return 0
>> }
>>
>
> OK with that change.
>
> Thanks,
> Pedro Alves
Pushed with that modification.
prev parent reply other threads:[~2015-03-04 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-04 21:44 Simon Marchi
2015-03-04 22:05 ` Pedro Alves
2015-03-04 22:58 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54F78E0B.2070004@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).