From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30793 invoked by alias); 6 Mar 2015 21:40:11 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 30783 invoked by uid 89); 6 Mar 2015 21:40:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 06 Mar 2015 21:40:10 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t26Le7nR003523 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 6 Mar 2015 16:40:08 -0500 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t26Le3Aa027470; Fri, 6 Mar 2015 16:40:07 -0500 Message-ID: <54FA1EB3.2050706@redhat.com> Date: Fri, 06 Mar 2015 21:40:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Mark Kettenis CC: gdb-patches@sourceware.org Subject: Re: [PATCH 2/6] Introduce throw_ptrace_error References: <1425671886-7798-1-git-send-email-palves@redhat.com> <1425671886-7798-3-git-send-email-palves@redhat.com> <201503062103.t26L3tef004332@glazunov.sibelius.xs4all.nl> In-Reply-To: <201503062103.t26L3tef004332@glazunov.sibelius.xs4all.nl> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00185.txt.bz2 On 03/06/2015 09:03 PM, Mark Kettenis wrote: >> From: Pedro Alves >> Date: Fri, 6 Mar 2015 19:58:02 +0000 >> >> This adds a new function that is meant to be called instead of >> perror_with_name whenever we get an error out of ptrace. The >> idea is to convert some errno errors to different GDB exceptions in >> a following patch. > > What is ptrace-specific about throwing an error? This really feels > like the wrong direction to me. Not exactly sure what you mean. Throwing an error is of course not ptrace-specific. What is ptrace-specific is the interpretation of errno. The end result of the series is that an ESRCH as a result of a ptrace error ends up throwing a THREAD_NOT_FOUND_ERROR error instead of a GENERIC_ERROR. Then callers up the chain can actually distinguish the errors. Please take a look at patch 3. It should make things clearer. Thanks, Pedro Alves