From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/3] Add vFile:fstat: packet to gdbserver
Date: Tue, 10 Mar 2015 18:31:00 -0000 [thread overview]
Message-ID: <54FF3878.8050202@redhat.com> (raw)
In-Reply-To: <1425902299-2151-3-git-send-email-gbenson@redhat.com>
On 03/09/2015 11:58 AM, Gary Benson wrote:
> This patch adds a new packet "vFile:fstat:" to gdbserver.
> This can be used by clients to retrieve information about
> open files.
Nit: Strictly speaking, it's a bit backwards to first add
packets to gdbserver that gdb doesn't support. In general,
I prefer that the gdb patch lands first, documenting the
packets/commands.
>
> gdb/ChangeLog:
>
> * NEWS: Announce new vFile:fstat packet.
>
> gdb/doc/ChangeLog:
>
> * gdb.texinfo (Host I/O Packets): Document vFile:fstat.
These changes above should be in the patch that teaches
GDB about the packets. Also, I think you're missing
documentation on the qSupported bits.
>
> gdb/gdbserver/ChangeLog:
>
> * hostio.c (sys/types.h): New include.
> (sys/stat.h): Likewise.
> (common-remote-fileio.h): Likewise.
> (handle_fstat): New function.
> (handle_vFile): Handle vFile:fstat packets.
> * server.c (handle_query): Report vFile:fstat as supported.
This part looks good.
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -37407,6 +37407,13 @@ packet is used. @samp{vFile:write} returns the number of bytes written,
> which may be shorter than the length of @var{data}, or -1 if an
> error occurred.
>
> +@item vFile:fstat: @var{fd}
> +Get information about the open file corresponding to @var{fd}.
> +On success the information is returned as a binary attachment
> +and the return value is the size of this attachment in bytes.
> +If an error occurs the return value is -1. The format of the
> +returned binary attachment is as described in @ref{struct stat}.
This should mention/reference the qSupported bit too.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-03-10 18:31 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 11:58 [PATCH 0/3] Properly implement remote_bfd_iovec_stat Gary Benson
2015-03-09 11:58 ` [PATCH 2/3] Add vFile:fstat: packet to gdbserver Gary Benson
2015-03-10 18:31 ` Pedro Alves [this message]
2015-03-11 10:33 ` [PATCH 2/3 v2] Implement vFile:fstat: packet in gdbserver Gary Benson
2015-03-11 11:35 ` Pedro Alves
2015-03-11 16:00 ` Eli Zaretskii
2015-03-09 11:58 ` [PATCH 3/3] Implement remote_bfd_iovec_stat using vFile:fstat Gary Benson
2015-03-09 16:17 ` Eli Zaretskii
2015-03-10 9:32 ` Gary Benson
2015-03-10 16:40 ` Eli Zaretskii
2015-03-10 11:20 ` [PATCH 3/3 v2] " Gary Benson
2015-03-10 15:51 ` [PATCH 3/3 v3] " Gary Benson
2015-03-10 18:31 ` Pedro Alves
2015-03-10 18:36 ` Pedro Alves
2015-03-11 10:23 ` Gary Benson
2015-03-11 11:22 ` Pedro Alves
2015-03-11 12:58 ` [PATCH 3/3 v4] Implement remote_bfd_iovec_stat Gary Benson
2015-03-11 13:15 ` Pedro Alves
2015-03-11 13:16 ` Gary Benson
2015-03-11 13:39 ` [PATCH 0/3 v2] Gary Benson
2015-03-11 18:04 ` [PATCH 0/3 v2] Properly implement remote_bfd_iovec_stat Gary Benson
2015-03-11 13:40 ` [PATCH 3/3 v3] Implement vFile:fstat: packet in gdbserver Gary Benson
2015-03-11 13:53 ` Pedro Alves
2015-03-11 13:40 ` [PATCH 2/3 v5] Implement remote_bfd_iovec_stat Gary Benson
2015-03-11 13:52 ` Pedro Alves
2015-03-11 13:40 ` [PATCH 1/3] Move remote_fileio_to_fio_stat to gdb/common Gary Benson
2015-03-09 11:58 ` Gary Benson
2015-03-10 18:30 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FF3878.8050202@redhat.com \
--to=palves@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).