From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-120598-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 41154 invoked by alias); 10 Mar 2015 18:31:38 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 41095 invoked by uid 89); 10 Mar 2015 18:31:37 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 10 Mar 2015 18:31:36 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2AIVYXP001924	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL)	for <gdb-patches@sourceware.org>; Tue, 10 Mar 2015 14:31:34 -0400
Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2AIVVJ5017876;	Tue, 10 Mar 2015 14:31:32 -0400
Message-ID: <54FF3883.70100@redhat.com>
Date: Tue, 10 Mar 2015 18:31:00 -0000
From: Pedro Alves <palves@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 3/3 v3] Implement remote_bfd_iovec_stat using vFile:fstat
References: <1425986407-18203-1-git-send-email-gbenson@redhat.com> <1426002678-30472-1-git-send-email-gbenson@redhat.com>
In-Reply-To: <1426002678-30472-1-git-send-email-gbenson@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2015-03/txt/msg00262.txt.bz2

On 03/10/2015 03:51 PM, Gary Benson wrote:
> 
> +
> +/* Unpack an fio_uint_t.  */
> +
> +static unsigned int
> +remote_fileio_to_host_uint (fio_uint_t fnum)
> +{
> +  gdb_byte *buf, *lim;
> +  unsigned int num = 0;
> +
> +  for (buf = (gdb_byte *) fnum, lim = buf + 4; buf < lim; buf++)
> +    {
> +      num <<= 8;
> +      num |= *buf;
> +    }

How about we use

  extract_unsigned_integer ((gdb_byte *) fnum, 4, BFD_ENDIAN_BIG)

instead?

Otherwise looks good.

Thanks,
Pedro Alves