From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68400 invoked by alias); 14 Sep 2016 18:32:50 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68147 invoked by uid 89); 14 Sep 2016 18:32:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Sep 2016 18:32:39 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6A947C05681A; Wed, 14 Sep 2016 18:32:38 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8EIWbp7012805; Wed, 14 Sep 2016 14:32:37 -0400 Subject: Re: [PATCH master+7.12 v2 1/3] Introduce cleanup to restore current_uiout To: Simon Marchi , Tom Tromey References: <20160914174548.5873-1-simon.marchi@ericsson.com> <20160914174548.5873-2-simon.marchi@ericsson.com> <878tuu4aje.fsf@tromey.com> <21ea4205-94b0-90a7-52f6-0014586f18a3@ericsson.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <54b273e3-b44b-3844-695b-cfc8bf5f7026@redhat.com> Date: Wed, 14 Sep 2016 18:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <21ea4205-94b0-90a7-52f6-0014586f18a3@ericsson.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-09/txt/msg00121.txt.bz2 On 09/14/2016 07:18 PM, Simon Marchi wrote: > On 16-09-14 02:10 PM, Tom Tromey wrote: >>>>>>> "Simon" == Simon Marchi writes: >> >> Simon> - old_chain = make_cleanup (restore_current_uiout_cleanup, current_uiout); >> Simon> + old_chain = make_cleanup_restore_current_uiout (); >> >> There's also already make_cleanup_restore_ui_out. >> You could just use "make_cleanup_restore_ui_out (¤t_uiout)" instead. >> >> Tom > > Ah good point, I'll probably do that. FWIW, I like the newer spelling better since we'll always be restoring current_uiout, but it's not a big deal at all. (similarly to https://sourceware.org/ml/gdb-patches/2016-09/msg00060.html) Thanks, Pedro Alves