From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 4180B3858D37 for ; Thu, 30 Nov 2023 18:01:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4180B3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4180B3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701367273; cv=none; b=ilTnEouzxtE0pzL0ojSR5L/VEHhQWqrBDmegdsvrbxGEooTQWCB9c3q4K8MPtfQDOg6+z+W/9Sb0Z+cP3MxBRUmrIXATMBWIagRZVzPwz4brPbZvWcUUsfa7A0vtopPYP/xVELpAJuKfQ/78AmzC5eoCwfqCZ3scc9cw8eX84N8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701367273; c=relaxed/simple; bh=812oYg5H0CZqGn1+Nz2tH7eHE0X8QKDu+mQLI3RENmU=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=YyMD4QRpOhnK2nRs+pqs8+mYGJOP68dFnvOm+B9WhdQv/EsjCiy9zJhRuU8UoTJaZMekBtAycm/nMV6XEuSHTMjdpkskxfTv4h0ev05sSsfi9dQBrw108TRTcfci7py43AF26SdiO/6vNLuBffxAPyw9z60xfPH17+uPrEqjX1E= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1701367271; bh=812oYg5H0CZqGn1+Nz2tH7eHE0X8QKDu+mQLI3RENmU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=wCWwe7tdOoJyBhXXCC5oM3w3QzPZKQVbAvS7XRONKKQgKRT7jr6Ybp1+wCPNb6ZYR Bzhl+GNwxoBEDlguvu4Ui6/1UMMmTAnmW5anCrHztB+beaVJiDdyTZbg1nrAclrPpJ S4l1av+Y30M3piVnQRVo41a1qK0tNsRaTFqmgJhs= Received: from [172.16.0.106] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 093431E091; Thu, 30 Nov 2023 13:01:10 -0500 (EST) Message-ID: <54c72205-4fd7-464e-b2f1-c5b55134301f@simark.ca> Date: Thu, 30 Nov 2023 13:01:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/24] gdb: use reg_buffer_common throughout gdbsupport/common-regcache.h Content-Language: fr To: "Aktemur, Tankut Baris" , Simon Marchi , "gdb-patches@sourceware.org" Cc: Luis Machado , John Baldwin , Andrew Burgess References: <20231124212656.96801-1-simon.marchi@efficios.com> <20231124212656.96801-3-simon.marchi@efficios.com> From: Simon Marchi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/30/23 11:11, Aktemur, Tankut Baris wrote: > On Friday, November 24, 2023 10:26 PM, Simon Marchi wrote: >> diff --git a/gdbserver/regcache.cc b/gdbserver/regcache.cc >> index 2e75a948a198..336b00008be5 100644 >> --- a/gdbserver/regcache.cc >> +++ b/gdbserver/regcache.cc >> @@ -21,6 +21,8 @@ >> #include "gdbthread.h" >> #include "tdesc.h" >> #include "gdbsupport/rsp-low.h" >> +#include "gdbsupport/gdb-checked-static-cast.h" >> + >> #ifndef IN_PROCESS_AGENT >> >> struct regcache * >> @@ -64,7 +66,7 @@ get_thread_regcache (struct thread_info *thread, int fetch) >> >> /* See gdbsupport/common-regcache.h. */ >> >> -struct regcache * >> +reg_buffer_common * >> get_thread_regcache_for_ptid (ptid_t ptid) >> { >> return get_thread_regcache (find_thread_ptid (ptid), 1); >> @@ -307,9 +309,10 @@ register_size (const struct target_desc *tdesc, int n) >> /* See gdbsupport/common-regcache.h. */ >> >> int >> -regcache_register_size (const struct regcache *regcache, int n) >> +regcache_register_size (const reg_buffer_common *regcache, int n) >> { >> - return register_size (regcache->tdesc, n); >> + return register_size >> + (gdb::checked_static_cast (regcache)->tdesc, n); >> } >> >> static unsigned char * >> @@ -437,13 +440,14 @@ regcache::raw_collect (int n, void *buf) const >> } >> >> enum register_status >> -regcache_raw_read_unsigned (struct regcache *regcache, int regnum, >> +regcache_raw_read_unsigned (reg_buffer_common *reg_buf, int regnum, >> ULONGEST *val) >> { >> int size; >> + regcache *regcache = gdb::checked_static_cast (reg_buf); >> >> gdb_assert (regcache != NULL); >> - >> + > > Trailing space seems to have been inserted here. Thanks, fixed. Simon