Re: [PATCH 1/2] Improve core file path detection & put cores in output dir

[Pedro Alves <pedro@palves.net>]

On 2022-06-24 10:50, Andrew Burgess wrote:

>>  # Check for production of a core file and remove it!
>> -
>> -set test "cleanup core file"
>> -if { [remote_file host exists core] } {
>> -    remote_file host delete core
>> -    pass "$test (removed)"
>> -} elseif { $pid != -1 && [remote_file host exists core.$pid] } {
>> -    remote_file host delete core.$pid
>> -    pass "$test (removed)"
>> -} else {
>> -    pass "$test (not dumped)"
>> -}
>> +remove_core $pid

...

>> +
>> +# Check for production of a core file and remove it.  PID is the
>> +# inferior's pid or -1 if not known.  TEST is the test's message.
>> +
>> +proc remove_core {pid {test ""}} {
>> +    if {$test == ""} {
>> +	set test "cleanup core file"
>> +    }
>> +
>> +    set file [find_core_file $pid]
>> +    if {$file != ""} {
>> +	remote_file host delete $file
>> +	pass "$test (removed)"
>> +    } else {
>> +	pass "$test (not dumped)"
> 
> I wonder if 'not found' would be a more acurate description for this
> last pass?  With a particular core file pattern it might be that there
> is a core file, we just can't find it, right?
> 
> Otherwise, this looks good.
> 

Yeah, I had just copied from that the annota testcases (see above).
I'll make that change before pushing this.  Thanks!