* [RFA] Initialize py_type_printers in ext_lang_type_printers
@ 2018-05-16 18:20 Tom Tromey
2018-05-17 13:25 ` Phil Muldoon
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2018-05-16 18:20 UTC (permalink / raw)
To: gdb-patches; +Cc: Tom Tromey
When running gdb in the build directory without passing
--data-directory, I noticed I could provoke a crash by:
$ ./gdb -nx ./gdb
(gdb) ptype/o struct dwarf2_per_objfile
... and then trying to "q" out at the pagination prompt.
valgrind complained about an uninitialized use of py_type_printers.
Initializing this member fixes the bug.
I believe this bug can occur even when the gdb Python libraries are
available, for example if get_type_recognizers fails.
Tested by hand on x86-64 Fedora 26. No test case because it seemed
difficult to guarantee failures.
gdb/ChangeLog
2018-05-16 Tom Tromey <tom@tromey.com>
* extension.h (struct ext_lang_type_printers) <py_type_printers>:
Initialize.
---
gdb/ChangeLog | 5 +++++
gdb/extension.h | 2 +-
2 files changed, 6 insertions(+), 1 deletion(-)
diff --git a/gdb/extension.h b/gdb/extension.h
index abde5e54e1..0c8c4ee934 100644
--- a/gdb/extension.h
+++ b/gdb/extension.h
@@ -152,7 +152,7 @@ struct ext_lang_type_printers
DISABLE_COPY_AND_ASSIGN (ext_lang_type_printers);
/* Type-printers from Python. */
- void *py_type_printers;
+ void *py_type_printers = nullptr;
};
/* The return code for some API calls. */
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Initialize py_type_printers in ext_lang_type_printers
2018-05-16 18:20 [RFA] Initialize py_type_printers in ext_lang_type_printers Tom Tromey
@ 2018-05-17 13:25 ` Phil Muldoon
2018-05-17 13:40 ` Pedro Alves
0 siblings, 1 reply; 3+ messages in thread
From: Phil Muldoon @ 2018-05-17 13:25 UTC (permalink / raw)
To: Tom Tromey, gdb-patches
On 16/05/18 18:43, Tom Tromey wrote:
> When running gdb in the build directory without passing
> --data-directory, I noticed I could provoke a crash by:
>
> $ ./gdb -nx ./gdb
> (gdb) ptype/o struct dwarf2_per_objfile
>
> ... and then trying to "q" out at the pagination prompt.
>
> valgrind complained about an uninitialized use of py_type_printers.
> Initializing this member fixes the bug.
>
> I believe this bug can occur even when the gdb Python libraries are
> available, for example if get_type_recognizers fails.
>
> Tested by hand on x86-64 Fedora 26. No test case because it seemed
> difficult to guarantee failures.
>
> gdb/ChangeLog
> 2018-05-16 Tom Tromey <tom@tromey.com>
>
> * extension.h (struct ext_lang_type_printers) <py_type_printers>:
> Initialize.
> ---
> gdb/ChangeLog | 5 +++++
> gdb/extension.h | 2 +-
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/extension.h b/gdb/extension.h
> index abde5e54e1..0c8c4ee934 100644
> --- a/gdb/extension.h
> +++ b/gdb/extension.h
> @@ -152,7 +152,7 @@ struct ext_lang_type_printers
> DISABLE_COPY_AND_ASSIGN (ext_lang_type_printers);
>
> /* Type-printers from Python. */
> - void *py_type_printers;
> + void *py_type_printers = nullptr;
> };
>
> /* The return code for some API calls. */
>
LGTM
Cheers
Phil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFA] Initialize py_type_printers in ext_lang_type_printers
2018-05-17 13:25 ` Phil Muldoon
@ 2018-05-17 13:40 ` Pedro Alves
0 siblings, 0 replies; 3+ messages in thread
From: Pedro Alves @ 2018-05-17 13:40 UTC (permalink / raw)
To: Phil Muldoon, Tom Tromey, gdb-patches
On 05/17/2018 11:32 AM, Phil Muldoon wrote:
> On 16/05/18 18:43, Tom Tromey wrote:
> LGTM
Thanks Phil. LGTM too.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-17 13:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 18:20 [RFA] Initialize py_type_printers in ext_lang_type_printers Tom Tromey
2018-05-17 13:25 ` Phil Muldoon
2018-05-17 13:40 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).