From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 93404 invoked by alias); 11 Mar 2015 19:55:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93387 invoked by uid 89); 11 Mar 2015 19:55:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 X-Spam-User: qpsmtpd, 2 recipients X-HELO: homiemail-a58.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a58.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 11 Mar 2015 19:55:21 +0000 Received: from homiemail-a58.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a58.g.dreamhost.com (Postfix) with ESMTP id 74A437D806C; Wed, 11 Mar 2015 12:55:20 -0700 (PDT) Received: from redwood.eagercon.com (c-24-7-16-38.hsd1.ca.comcast.net [24.7.16.38]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: eager@eagerm.com) by homiemail-a58.g.dreamhost.com (Postfix) with ESMTPSA id 022317D806A; Wed, 11 Mar 2015 12:55:19 -0700 (PDT) Message-ID: <55009DA7.4070504@eagerm.com> Date: Wed, 11 Mar 2015 19:55:00 -0000 From: Michael Eager User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Eli Zaretskii CC: gdb-patches@sourceware.org, binutils@sourceware.org Subject: Re: [PATCH] Support gzip compressed exec and core files in gdb References: <54FF77D6.7010400@eagerm.com> <83y4n34ik9.fsf@gnu.org> In-Reply-To: <83y4n34ik9.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00318.txt.bz2 On 03/11/15 09:15, Eli Zaretskii wrote: >> Date: Tue, 10 Mar 2015 16:01:42 -0700 >> From: Michael Eager >> >> GDB/DOC: >> * gdb.texinfo: Mention gzipped exec and core files. > > This should mention the name of the node where you make changes; see > the other ChangeLog entries in gdb/doc/. > > Do we need a NEWS entry for this? > >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -17391,6 +17391,11 @@ via @code{gdbserver} (@pxref{Server, file, Using the @code{gdbserver} >> Program}). In these situations the @value{GDBN} commands to specify >> new files are useful. >> >> +Executable and core files may be compressed using @code{gzip}. These > > 'gzip' is a command, so please use @command, not @code. > >> +files will be uncompressed into temporary files either in /tmp > > '/tmp' is a file name, so please use @file for its markup. > >> or in >> +@code{$TMPDIR} if this is set in the environment. > > I'd prefer to say > > in the system-wide temporary directory > > and mention neither /tmp nor $TMPDIR, as both are platform-dependent. I think it might be good to tell people how to specify where the uncompressed file is located. > > Otherwise, the documentation parts are OK. Thanks. I'll make the changes. > I agree with Mike that it's better to use library functions for > creating temporary files, since that hides platform dependencies. The code uses mkstemp() to create a temporary file. Is there a GDB or BFD wrapper for this function? -- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077