From: Pedro Alves <palves@redhat.com>
To: Christian Biesinger <cbiesinger@google.com>,
gdb-patches <gdb-patches@sourceware.org>,
Simon Marchi <simark@simark.ca>
Subject: Re: [PATCH v2] Add gdb::nullopt, from C++17's std::nullopt
Date: Wed, 3 Jun 2020 10:56:35 +0100 [thread overview]
Message-ID: <55056af6-ad5e-5973-bff8-c6f96b4a28b3@redhat.com> (raw)
In-Reply-To: <CAPTJ0XHBeQTcmBMMuRNw_vAz6KjhRYoxqhJ-DDqZ75HpEdSgAQ@mail.gmail.com>
On 6/2/20 9:27 PM, Christian Biesinger via Gdb-patches wrote:
> Ping? Simon/Pedro, any thoughts?
As I had said on IRC a few days ago:
<palves> I remember not including std::nullopt in the original gdb::optional patch for some reason.
<palves> but I don't remember what reason it was.
<palves> maybe it was an C++17 inline variable or something.
<palves> if it works, and the tests pass, I'm happy. ship it.
BTW, was this implementation borrowed from libstdc++; or put another
way, did you take a look at the implementation from libstdc++, see if
there's anything there taking care of some non-obvious issue, that we
should mimic?
Thanks,
Pedro Alves
prev parent reply other threads:[~2020-06-03 9:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 18:55 [PATCH] " cbiesinger
2020-05-19 19:15 ` Simon Marchi
2020-05-19 19:27 ` [PATCH v2] " cbiesinger
2020-06-02 20:27 ` Christian Biesinger
2020-06-02 20:39 ` Simon Marchi
2020-06-03 9:56 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55056af6-ad5e-5973-bff8-c6f96b4a28b3@redhat.com \
--to=palves@redhat.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).