From: Jiri Gaisler <jiri@gaisler.se>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 03/13] sim/erc32: Switched emulated memory to host endian order.
Date: Mon, 23 Mar 2015 09:01:00 -0000 [thread overview]
Message-ID: <550FD646.7040905@gaisler.se> (raw)
In-Reply-To: <20150323024519.GB8039@vapier>
[-- Attachment #1: Type: text/plain, Size: 505 bytes --]
On 23/03/15 03:45, Mike Frysinger wrote:
> On 17 Mar 2015 22:02, Jiri Gaisler wrote:
>> --- a/sim/erc32/erc32.c
>> +++ b/sim/erc32/erc32.c
>> +#ifdef HOST_LITTLE_ENDIAN
>> + waddr ^= 3;
>> +#endif
>> + mem[waddr] = *data & 0x0ff;
>
> doesn't this assume the target is big endian ? this shows up a few times in
> the changes to this file.
>
The target (SPARC) is always big endian, so I believe this is correct.
I will fix the rest of your comments and resend.
Jiri.
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
next prev parent reply other threads:[~2015-03-23 9:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 21:03 [PATCH v4 00/13] Update of the SPARC SIS simulator Jiri Gaisler
2015-03-17 21:03 ` [PATCH v4 01/13] sim/erc32: Added -v command line switch for verbose output Jiri Gaisler
2015-03-17 22:56 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 05/13] sim/erc32: Fix a few compiler warnings Jiri Gaisler
2015-03-28 7:06 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 03/13] sim/erc32: Switched emulated memory to host endian order Jiri Gaisler
2015-03-22 22:46 ` Mike Frysinger
2015-03-23 9:01 ` Jiri Gaisler [this message]
2015-03-28 7:41 ` Mike Frysinger
2015-03-28 8:21 ` Jiri Gaisler
2015-03-24 9:39 ` Jiri Gaisler
2015-03-27 10:26 ` Jiri Gaisler
2015-03-17 21:03 ` [PATCH v4 02/13] sim/erc32: Removed type mismatch compiler warnings Jiri Gaisler
2015-03-17 22:59 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 10/13] sim/erc32: Add support for LEON2 processor emulation Jiri Gaisler
2015-03-28 7:21 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 09/13] sim/erc32: Add support for LEON3 " Jiri Gaisler
2015-03-17 21:03 ` [PATCH v4 04/13] sim/erc32: Use memory_iread() function for instruction fetching Jiri Gaisler
2015-03-28 7:01 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 06/13] sim/erc32: Use gdb callback for UART I/O when linked with gdb Jiri Gaisler
2015-03-28 7:13 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 07/13] sim/erc32: Access memory subsystem through struct memsys Jiri Gaisler
2015-03-28 7:15 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 11/13] sim/erc32: Updated documentation Jiri Gaisler
2015-03-28 7:17 ` Mike Frysinger
2015-03-17 21:03 ` [PATCH v4 12/13] sim/erc32: Add data watchpoint support Jiri Gaisler
2015-03-28 7:16 ` Mike Frysinger
2015-03-17 21:04 ` [PATCH v4 08/13] sim/erc32: Move local extern declarations into sis.h Jiri Gaisler
2015-03-17 21:04 ` [PATCH v4 13/13] Add watchpoint support to gdb simulator interface Jiri Gaisler
2015-03-28 7:19 ` Mike Frysinger
2015-03-30 20:51 ` Jiri Gaisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550FD646.7040905@gaisler.se \
--to=jiri@gaisler.se \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).