* [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin
@ 2015-03-06 13:01 Jon TURNEY
2015-03-18 23:34 ` Pedro Alves
0 siblings, 1 reply; 7+ messages in thread
From: Jon TURNEY @ 2015-03-06 13:01 UTC (permalink / raw)
To: gdb-patches; +Cc: Jon TURNEY
Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for
x86_64-*-cygwin
I'm not sure that testsuite results on x86_64-*-cygwin tell you a great deal,
but for the record:
-# of expected passes 20510
-# of unexpected failures 649
+# of expected passes 21456
+# of unexpected failures 729
# of unexpected successes 2
# of expected failures 42
-# of known failures 50
-# of untested testcases 90
-# of unresolved testcases 9
-# of unsupported tests 114
+# of known failures 52
+# of untested testcases 80
+# of unresolved testcases 184
+# of unsupported tests 118
ChangeLog/gdb/testuite:
2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk>
* lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
SYMBOL_PREFIX for x86_64-*-cygwin.
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
---
gdb/testsuite/lib/gdb.exp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index f274b64..0041adf 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -4998,7 +4998,7 @@ proc core_find {binfile {deletefiles {}} {arg ""}} {
# TODO: find out automatically if the target needs this.
proc gdb_target_symbol_prefix_flags {} {
- if { [istarget "*-*-cygwin*"] || [istarget "i?86-*-mingw*"]
+ if { [istarget "i?86-*-cygwin*"] || [istarget "i?86-*-mingw*"]
|| [istarget "*-*-msdosdjgpp*"] || [istarget "*-*-go32*"] } {
return "additional_flags=-DSYMBOL_PREFIX=\"_\""
} else {
--
2.1.4
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin
2015-03-06 13:01 [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin Jon TURNEY
@ 2015-03-18 23:34 ` Pedro Alves
2015-03-20 16:06 ` Jon TURNEY
0 siblings, 1 reply; 7+ messages in thread
From: Pedro Alves @ 2015-03-18 23:34 UTC (permalink / raw)
To: Jon TURNEY, gdb-patches
On 03/06/2015 01:01 PM, Jon TURNEY wrote:
> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for
> x86_64-*-cygwin
>
> I'm not sure that testsuite results on x86_64-*-cygwin tell you a great deal,
> but for the record:
>
> -# of expected passes 20510
> -# of unexpected failures 649
> +# of expected passes 21456
> +# of unexpected failures 729
> # of unexpected successes 2
> # of expected failures 42
> -# of known failures 50
> -# of untested testcases 90
> -# of unresolved testcases 9
> -# of unsupported tests 114
> +# of known failures 52
> +# of untested testcases 80
> +# of unresolved testcases 184
> +# of unsupported tests 118
>
> ChangeLog/gdb/testuite:
>
> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk>
>
> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
> SYMBOL_PREFIX for x86_64-*-cygwin.
OK.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin
2015-03-18 23:34 ` Pedro Alves
@ 2015-03-20 16:06 ` Jon TURNEY
2015-03-20 17:23 ` Pedro Alves
0 siblings, 1 reply; 7+ messages in thread
From: Jon TURNEY @ 2015-03-20 16:06 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
On 18/03/2015 23:34, Pedro Alves wrote:
> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for
>> x86_64-*-cygwin
[...]
>> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk>
>>
>> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>> SYMBOL_PREFIX for x86_64-*-cygwin.
>
> OK.
I do not have write access, so can you apply this, please.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin
2015-03-20 16:06 ` Jon TURNEY
@ 2015-03-20 17:23 ` Pedro Alves
2015-03-23 14:39 ` Jon TURNEY
0 siblings, 1 reply; 7+ messages in thread
From: Pedro Alves @ 2015-03-20 17:23 UTC (permalink / raw)
To: Jon TURNEY, gdb-patches
On 03/20/2015 04:06 PM, Jon TURNEY wrote:
> On 18/03/2015 23:34, Pedro Alves wrote:
>> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for
>>> x86_64-*-cygwin
> [...]
>>> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk>
>>>
>>> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>>> SYMBOL_PREFIX for x86_64-*-cygwin.
>>
>> OK.
>
> I do not have write access, so can you apply this, please.
Are you planning on working on GDB further? (That'd be
awesome, btw.) We can get you write access so you can
push your own patches. Let me know if you'd like that.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin
2015-03-20 17:23 ` Pedro Alves
@ 2015-03-23 14:39 ` Jon TURNEY
2015-03-25 17:51 ` Jon TURNEY
0 siblings, 1 reply; 7+ messages in thread
From: Jon TURNEY @ 2015-03-23 14:39 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
On 20/03/2015 17:23, Pedro Alves wrote:
> On 03/20/2015 04:06 PM, Jon TURNEY wrote:
>> On 18/03/2015 23:34, Pedro Alves wrote:
>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_" for
>>>> x86_64-*-cygwin
>> [...]
>>>> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk>
>>>>
>>>> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>>>> SYMBOL_PREFIX for x86_64-*-cygwin.
>>>
>>> OK.
>>
>> I do not have write access, so can you apply this, please.
>
> Are you planning on working on GDB further? (That'd be
> awesome, btw.) We can get you write access so you can
> push your own patches. Let me know if you'd like that.
Yes, please.
I already have a sourceware account, 'jturney'.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin
2015-03-23 14:39 ` Jon TURNEY
@ 2015-03-25 17:51 ` Jon TURNEY
2015-03-26 9:28 ` Pedro Alves
0 siblings, 1 reply; 7+ messages in thread
From: Jon TURNEY @ 2015-03-25 17:51 UTC (permalink / raw)
To: Pedro Alves, gdb-patches
On 23/03/2015 14:39, Jon TURNEY wrote:
> On 20/03/2015 17:23, Pedro Alves wrote:
>> On 03/20/2015 04:06 PM, Jon TURNEY wrote:
>>> On 18/03/2015 23:34, Pedro Alves wrote:
>>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_"
>>>>> for
>>>>> x86_64-*-cygwin
>>> [...]
>>>>> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk>
>>>>>
>>>>> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>>>>> SYMBOL_PREFIX for x86_64-*-cygwin.
>>>>
>>>> OK.
>>>
>>> I do not have write access, so can you apply this, please.
>>
>> Are you planning on working on GDB further? (That'd be
>> awesome, btw.) We can get you write access so you can
>> push your own patches. Let me know if you'd like that.
>
> Yes, please.
So it seems I do have write access, although I didn't know this :-)
Can I go ahead and commit this?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin
2015-03-25 17:51 ` Jon TURNEY
@ 2015-03-26 9:28 ` Pedro Alves
0 siblings, 0 replies; 7+ messages in thread
From: Pedro Alves @ 2015-03-26 9:28 UTC (permalink / raw)
To: Jon TURNEY, gdb-patches
On 03/25/2015 05:51 PM, Jon TURNEY wrote:
> On 23/03/2015 14:39, Jon TURNEY wrote:
>> On 20/03/2015 17:23, Pedro Alves wrote:
>>> On 03/20/2015 04:06 PM, Jon TURNEY wrote:
>>>> On 18/03/2015 23:34, Pedro Alves wrote:
>>>>> On 03/06/2015 01:01 PM, Jon TURNEY wrote:
>>>>>> Exactly like x86_64-*-mingw, SYMBOL_PREFIX should not be set to "_"
>>>>>> for
>>>>>> x86_64-*-cygwin
>>>> [...]
>>>>>> 2015-03-04 Jon TURNEY <jon.turney@dronecode.org.uk>
>>>>>>
>>>>>> * lib/gdb.exp (gdb_target_symbol_prefix_flags): Don't set
>>>>>> SYMBOL_PREFIX for x86_64-*-cygwin.
>>>>>
>>>>> OK.
>>>>
>>>> I do not have write access, so can you apply this, please.
>>>
>>> Are you planning on working on GDB further? (That'd be
>>> awesome, btw.) We can get you write access so you can
>>> push your own patches. Let me know if you'd like that.
>>
>> Yes, please.
>
> So it seems I do have write access, although I didn't know this :-)
>
:-)
> Can I go ahead and commit this?
Yes.
Please add yourself to write-after-approval section of
the gdb/MAINTAINERS file. No need for approval for that
one. Just post the patch/commit to the list for the archives.
Thanks,
Pedro Alves
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-03-26 9:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-06 13:01 [PATCH] testsuite: Don't set SYMBOL_PREFIX for x86_64-*-cygwin Jon TURNEY
2015-03-18 23:34 ` Pedro Alves
2015-03-20 16:06 ` Jon TURNEY
2015-03-20 17:23 ` Pedro Alves
2015-03-23 14:39 ` Jon TURNEY
2015-03-25 17:51 ` Jon TURNEY
2015-03-26 9:28 ` Pedro Alves
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).