From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27448 invoked by alias); 24 Mar 2015 10:57:25 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27434 invoked by uid 89); 24 Mar 2015 10:57:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 24 Mar 2015 10:57:24 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2OAvKUR023709 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 24 Mar 2015 06:57:21 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2OAvItv024612; Tue, 24 Mar 2015 06:57:19 -0400 Message-ID: <5511430E.7040608@redhat.com> Date: Tue, 24 Mar 2015 10:57:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Don Breazeal , gdb-patches@sourceware.org Subject: Re: [PATCH v6 1/6] Identify remote fork event support References: <1424997977-13316-1-git-send-email-donb@codesourcery.com> <1426625788-4469-1-git-send-email-donb@codesourcery.com> <1426625788-4469-2-git-send-email-donb@codesourcery.com> In-Reply-To: <1426625788-4469-2-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00786.txt.bz2 On 03/17/2015 08:56 PM, Don Breazeal wrote: > @@ -12508,7 +12524,8 @@ Show the maximum size of the address (in bits) in a memory packet."), NULL, > add_packet_config_cmd (&remote_protocol_packets[PACKET_hwbreak_feature], > "hwbreak-feature", "hwbreak-feature", 0); > > - /* Assert that we've registered commands for all packet configs. */ > + /* Assert that we've registered "set remote foo-packet" commands > + for all packet configs. */ > { > int i; > This hunk could go immediately/separately as obvious. > @@ -12527,6 +12544,8 @@ Show the maximum size of the address (in bits) in a memory packet."), NULL, > case PACKET_DisconnectedTracing_feature: > case PACKET_augmented_libraries_svr4_read_feature: > case PACKET_qCRC: > + case PACKET_fork_event_feature: > + case PACKET_vfork_event_feature: > /* Additions to this list need to be well justified: > pre-existing packets are OK; new packets are not. */ I think I mentioned this before: please do register commands for these features. As the comment says, new packets here are not OK without good justification, and I can't think of a good justification. Then you'll need to make sure remote_query_supported only includes the feature in GDB's query if the feature wasn't force-disabled. See the new swbreak+ feature's handling in that function. > excepted = 1; Thanks, Pedro Alves