From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85920 invoked by alias); 27 Mar 2015 12:41:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85910 invoked by uid 89); 27 Mar 2015 12:41:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 Mar 2015 12:41:45 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 45B3F8E3CC; Fri, 27 Mar 2015 12:41:44 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2RCfg66027464; Fri, 27 Mar 2015 08:41:42 -0400 Message-ID: <55155005.5010105@redhat.com> Date: Fri, 27 Mar 2015 12:41:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Andrzej Kaczmarek , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix gdb_bfd_section_index() for special sections References: <1426602364-4984-1-git-send-email-andrzej.kaczmarek@tieto.com> In-Reply-To: <1426602364-4984-1-git-send-email-andrzej.kaczmarek@tieto.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-03/txt/msg00901.txt.bz2 On 03/17/2015 02:26 PM, Andrzej Kaczmarek wrote: > Indexes returned for special sections are off by one, i.e. with N+4 > sections last one has index N+4 returned which is outside allocated > obstack (at the same time index N is not used at all). > > In worst case, if sections obstack is allocated up to end of chunk, > writing last section data will cause buffer overrun and some data > corruption. Regression tested on x86_64 Fedora 20, and pushed. Thanks, -- Pedro Alves