From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 115418 invoked by alias); 27 Mar 2015 17:34:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115407 invoked by uid 89); 27 Mar 2015 17:34:18 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 27 Mar 2015 17:34:17 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t2RHYDIb030712 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 27 Mar 2015 13:34:13 -0400 Received: from valrhona.uglyboxes.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t2RHYBDm014215 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 27 Mar 2015 13:34:12 -0400 Message-ID: <55159493.20005@redhat.com> Date: Fri, 27 Mar 2015 17:34:00 -0000 From: Keith Seitz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Antoine Tremblay , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix MI dprintf-insert not printing when a location is pending. References: <55154E63.5040603@ericsson.com> <1427459819-29661-1-git-send-email-antoine.tremblay@ericsson.com> <55158AAF.7010709@redhat.com> <55158F97.7030400@ericsson.com> In-Reply-To: <55158F97.7030400@ericsson.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-03/txt/msg00916.txt.bz2 On 03/27/2015 10:12 AM, Antoine Tremblay wrote: > However there is still a problem forcing me to use gdb_expect I think, > namely mi_gdb_test waits for a command prompt like so : > > -re "^($string_regex\[\r\n\]+)?($pattern\[\r\n\]+$mi_gdb_prompt\[ \]*)" > > However dprintf does mean you will get a prompt printed... > > You will get a prompt only when hitting the breakpoint I placed. Ick. Yeah, you are right. My bad. > I could remove mi_expect_stop at the end and assume that breakpoint will > not fail but I think it's not right ? also mi-dprintf.exp is using the > same mi_run_cmd / gdb_expect / mi_expect_stop ... > > What do you think ? I think everything is fine as it is. Sorry about the noise. So, once again, while I am not a maintainer, I recommend a maintainer approve this patch. Thank you for your patience, Keith