From: Simon Marchi <simon.marchi@ericsson.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>, <gdb-patches@sourceware.org>
Subject: Re: [obv] Code cleanup: Move print_command_1 expr variable scope
Date: Fri, 27 Mar 2015 19:15:00 -0000 [thread overview]
Message-ID: <5515AC41.1040907@ericsson.com> (raw)
In-Reply-To: <20150326174630.GA3349@host1.jankratochvil.net>
Hi Jan,
I think this patch is wrong. Starting with that commit (f30d5c7),
some tests (e.g. mi-break.exp) started to fail for me, because
of gdb segfaulting. Backtrace here: http://paste.ubuntu.com/10690836/
The address of expr is passed to the cleanup. When the cleanup is ran,
expr is no longer in scope, so what is at that address is probably not
safe to use anymore. That's my guess.
Simon
next prev parent reply other threads:[~2015-03-27 19:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 17:46 Jan Kratochvil
2015-03-27 19:15 ` Simon Marchi [this message]
2015-03-27 19:22 ` Revert: " Jan Kratochvil
2015-03-27 19:24 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5515AC41.1040907@ericsson.com \
--to=simon.marchi@ericsson.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).