From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 1/9] Introduce target_fileio_fstat
Date: Wed, 01 Apr 2015 12:11:00 -0000 [thread overview]
Message-ID: <551BE069.4040502@redhat.com> (raw)
In-Reply-To: <1426870087-32654-2-git-send-email-gbenson@redhat.com>
Looks good with the nits below addressed.
On 03/20/2015 04:47 PM, Gary Benson wrote:
> --- a/gdb/inf-child.c
> +++ b/gdb/inf-child.c
> @@ -374,6 +374,22 @@ inf_child_fileio_pread (struct target_ops *self,
> return ret;
> }
>
> +/* Get information about the file opened as FD and put it in SB.
> + Return 0, or -1 if an error occurs (and set *TARGET_ERRNO). */
Write something like "Implementation of to_fileio_fstat."
instead of duplicating the comment.
> +
> +static int
> +inf_child_fileio_fstat (struct target_ops *self, int fd,
> + struct stat *sb, int *target_errno)
> +{
> index bb901b5..44ede10 100644
> --- a/gdb/target.c
> +++ b/gdb/target.c
> @@ -2848,6 +2848,27 @@ target_fileio_pread (int fd, gdb_byte *read_buf, int len,
> return ret;
> }
>
> +/* Get information about the file opened as FD on the target
> + and put it in SB. Return 0, or -1 if an error occurs (and
> + set *TARGET_ERRNO). */
Write:
/* See target.h. */
instead of duplicating the comment.
> +int
> +target_fileio_fstat (int fd, struct stat *sb, int *target_errno)
> +{
> + fileio_fh_t *fh = fileio_fd_to_fh (fd);
> + int ret = -1;
> +
> + if (is_closed_fileio_fh (fh->fd))
> + *target_errno = EBADF;
> + else
> + ret = fh->t->to_fileio_fstat (fh->t, fh->fd, sb, target_errno);
> +
> + if (targetdebug)
> + fprintf_unfiltered (gdb_stdlog,
> + "target_fileio_fstat (%d) = %d (%d)\n",
> + fd, ret, ret != -1 ? 0 : *target_errno);
> + return ret;
> +}
> +
> /* Close FD on the target. Return 0, or -1 if an error occurs
> (and set *TARGET_ERRNO). */
> int
> diff --git a/gdb/target.h b/gdb/target.h
> index c95e1a4..d2bd152 100644
> --- a/gdb/target.h
> +++ b/gdb/target.h
> @@ -846,6 +846,11 @@ struct target_ops
> int fd, gdb_byte *read_buf, int len,
> ULONGEST offset, int *target_errno);
>
> + /* Get information about the file opened as FD and put it in SB.
> + Return 0, or -1 if an error occurs (and set *TARGET_ERRNO). */
ITYM, "Return 0 on success, ..."
> + int (*to_fileio_fstat) (struct target_ops *,
> + int fd, struct stat *sb, int *target_errno);
> +
> +/* Get information about the file opened as FD on the target
> + and put it in SB. Return 0, or -1 if an error occurs (and
Likewise.
> + set *TARGET_ERRNO). */
> +extern int target_fileio_fstat (int fd, struct stat *sb,
> + int *target_errno);
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-04-01 12:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-20 16:48 [PATCH 0/9] New default sysroot "target:" Gary Benson
2015-03-20 16:48 ` [PATCH 4/9] Convert "remote:" sysroots to "target:" and remove "remote:" Gary Benson
2015-04-01 12:13 ` Pedro Alves
2015-04-01 13:48 ` Gary Benson
2015-03-20 16:48 ` [PATCH 6/9] Strip "target:" prefix in solib_find if accessing local files Gary Benson
2015-04-01 12:14 ` Pedro Alves
2015-03-20 16:48 ` [PATCH 1/9] Introduce target_fileio_fstat Gary Benson
2015-04-01 12:11 ` Pedro Alves [this message]
2015-03-20 16:57 ` [PATCH 8/9] Make the default sysroot be "target:" Gary Benson
2015-04-01 12:15 ` Pedro Alves
2015-04-01 14:12 ` Gary Benson
2015-04-01 14:18 ` Pedro Alves
2015-03-20 16:57 ` [PATCH 9/9] Document "target:" sysroot changes Gary Benson
2015-03-20 17:51 ` Eli Zaretskii
2015-04-01 12:15 ` Pedro Alves
2015-03-20 17:18 ` [PATCH 7/9] Update exec_file_attach to cope with "target:" filenames Gary Benson
2015-04-01 12:14 ` Pedro Alves
2015-04-01 13:55 ` Gary Benson
2015-04-01 14:16 ` Pedro Alves
2015-04-01 15:59 ` Gary Benson
2015-03-20 17:32 ` [PATCH 2/9] Introduce target_filesystem_is_local Gary Benson
2015-04-01 12:11 ` Pedro Alves
2015-03-20 17:46 ` [PATCH 5/9] Rearrange symfile_bfd_open Gary Benson
2015-04-01 12:13 ` Pedro Alves
2015-04-01 15:50 ` Gary Benson
2015-04-01 16:03 ` Pedro Alves
2015-03-20 17:47 ` [PATCH 3/9] Make gdb_bfd_open able to open BFDs using target fileio Gary Benson
2015-04-01 12:13 ` Pedro Alves
2015-04-01 12:17 ` [PATCH 0/9] New default sysroot "target:" Pedro Alves
2015-04-02 13:00 ` Gary Benson
2015-04-01 12:22 ` [PING][PATCH " Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551BE069.4040502@redhat.com \
--to=palves@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).