public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] kfail two tests in no-unwaited-for-left.exp for remote target
@ 2015-03-26 11:54 Yao Qi
  2015-04-02 12:53 ` Yao Qi
  0 siblings, 1 reply; 2+ messages in thread
From: Yao Qi @ 2015-03-26 11:54 UTC (permalink / raw)
  To: gdb-patches

From: Yao Qi <yao.qi@linaro.org>

I see these two fails in no-unwaited-for-left.exp in remote testing
for aarch64-linux target.

...
continue
Continuing.
warning: Remote failure reply: E.No unwaited-for children left.

[Thread 1084] #2 stopped.
(gdb) FAIL: gdb.threads/no-unwaited-for-left.exp: continue stops when thread 2 exits

....
continue
Continuing.
warning: Remote failure reply: E.No unwaited-for children left.

[Thread 1081] #1 stopped.
(gdb) FAIL: gdb.threads/no-unwaited-for-left.exp: continue stops when the main thread exits

I checked the gdb.log on buildbot, and find that these two fails also
appear on Debian-i686-native-extended-gdbserver and Fedora-ppc64be-native-gdbserver-m64.
I recall that they are about local/remote parity, and related RSP is missing.
There has been already a PR 14618 about it.  This patch is to kfail them
on remote target.

gdb/testsuite:

2015-03-26  Yao Qi  <yao.qi@linaro.org>

	* gdb.threads/no-unwaited-for-left.exp: Set up kfail if target
	is remote.
---
 gdb/testsuite/gdb.threads/no-unwaited-for-left.exp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gdb/testsuite/gdb.threads/no-unwaited-for-left.exp b/gdb/testsuite/gdb.threads/no-unwaited-for-left.exp
index 518301e..3a43d58 100644
--- a/gdb/testsuite/gdb.threads/no-unwaited-for-left.exp
+++ b/gdb/testsuite/gdb.threads/no-unwaited-for-left.exp
@@ -37,6 +37,9 @@ gdb_test_no_output "set scheduler-locking on" \
     "enable scheduler-locking, for thread 2"
 
 # Continue.  Thread 2 exits, and the main thread was already stopped.
+if [is_remote target] {
+    setup_kfail "gdb/14618" "*-*-*"
+}
 gdb_test "continue" \
     "No unwaited-for children left." \
     "continue stops when thread 2 exits"
@@ -58,6 +61,9 @@ gdb_continue_to_breakpoint "break-here-2" ".* break-here-2 .*"
 gdb_test_no_output "set scheduler-locking on" \
     "enable scheduler-locking, for main thread"
 # The main thread exits, and thread 3 was already stopped.
+if [is_remote target] {
+    setup_kfail "gdb/14618" "*-*-*"
+}
 gdb_test "continue" \
     "No unwaited-for children left." \
     "continue stops when the main thread exits"
-- 
1.9.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] kfail two tests in no-unwaited-for-left.exp for remote target
  2015-03-26 11:54 [PATCH] kfail two tests in no-unwaited-for-left.exp for remote target Yao Qi
@ 2015-04-02 12:53 ` Yao Qi
  0 siblings, 0 replies; 2+ messages in thread
From: Yao Qi @ 2015-04-02 12:53 UTC (permalink / raw)
  To: gdb-patches

On 26/03/15 11:54, Yao Qi wrote:
> gdb/testsuite:
>
> 2015-03-26  Yao Qi<yao.qi@linaro.org>
>
> 	* gdb.threads/no-unwaited-for-left.exp: Set up kfail if target
> 	is remote.

I've pushed it in.

-- 
Yao (齐尧)

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-04-02 12:53 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-03-26 11:54 [PATCH] kfail two tests in no-unwaited-for-left.exp for remote target Yao Qi
2015-04-02 12:53 ` Yao Qi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).