From: Phil Muldoon <pmuldoon@redhat.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Subject: Re: [python][patch] Python rbreak
Date: Fri, 13 Oct 2017 08:08:00 -0000 [thread overview]
Message-ID: <551c566b-1767-71f8-50cd-260acbb20d40@redhat.com> (raw)
In-Reply-To: <f39f6365-fc45-ea7d-10dc-5e0053db5cbb@redhat.com>
On 11/10/17 12:30, Phil Muldoon wrote:
> This introduces a Python rbreak function to the Python API. Its
> functionality was designed to closely match that of the console rbreak
> but with a number of caveats.
> +
> + gdbpy_ref<> argList (Py_BuildValue("(s)", symbol_name.c_str ()));
> + gdbpy_ref<> obj (PyObject_CallObject ((PyObject *)
> + &breakpoint_object_type,
> + argList.get ()));
> +
> + /* Tolerate individual breakpoint failures. */
> + if (obj == NULL)
> + gdbpy_print_stack ();
> + else
> + {
> + PyTuple_SET_ITEM (return_tuple.get (), count, obj.get ());
> + count++;
Not sure how I missed this on the first patch run, but that obj.get ()
should be obj.release (). Apologies for noise and fixed locally.
Cheers
Phil
next prev parent reply other threads:[~2017-10-13 8:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-11 11:30 Phil Muldoon
2017-10-11 12:11 ` Eli Zaretskii
2017-10-11 12:27 ` Phil Muldoon
2017-10-11 16:19 ` Kevin Buettner
2017-10-11 16:24 ` Phil Muldoon
2017-10-13 8:08 ` Phil Muldoon [this message]
2017-10-16 22:22 ` Simon Marchi
2017-10-16 23:01 ` Phil Muldoon
2017-10-17 0:24 ` Simon Marchi
2017-11-03 9:46 ` Phil Muldoon
2017-11-03 10:05 ` Eli Zaretskii
2017-11-13 19:29 ` Phil Muldoon
2018-02-01 9:47 ` [RFA/RFC] Clarify contents of NEWS entry re: Python "rbreak" (waa: "Re: [python][patch] Python rbreak") Joel Brobecker
2018-02-01 10:26 ` Phil Muldoon
2018-02-01 16:21 ` Eli Zaretskii
2018-02-01 17:32 ` Joel Brobecker
2018-02-01 18:25 ` Eli Zaretskii
2018-02-02 3:16 ` Joel Brobecker
2018-02-09 4:30 ` Joel Brobecker
2018-02-09 9:26 ` Eli Zaretskii
2018-02-09 12:13 ` Joel Brobecker
2017-11-14 20:23 ` [python][patch] Python rbreak Simon Marchi
2017-11-16 14:19 ` Phil Muldoon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=551c566b-1767-71f8-50cd-260acbb20d40@redhat.com \
--to=pmuldoon@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).