Re: [pushed] [gdb/testsuite] Fix gdb.threads/dlopen-libpthread.exp for upstream glibc

[Tom de Vries <tdevries@suse.de>]

On 1/10/23 19:05, Simon Marchi wrote:
>> Attached patch fixes things.
>>
>> WDYT?
>>
>> Thanks,
>> - Tom
> 
> 
> Here:
> 
>> # We link the exec without -lpthread, but libpthread.so may already be loaded at main
>> # due to LD_PRELOAD.
>> set libpthread_maybe_preloaded 0
>> set binfile [standard_output_file $executable]
>> if { [has_dependency $binfile libpthread\\.so] == 1 } {
>>      set libpthread_maybe_preloaded 1
>> }
> 
> Ok, so this works because ldd is influenced by LD_PRELOAD, I didn't
> know.
> 

Yes, while lddtree is not, which had me confused for a while.

>>
>> # We link the shlib with -lpthread, but since glibc 2.34 libpthread has been
>> # merged with libc, so libpthread.so may not be a dependency.
>> set libpthread_missing 0
>> if { [has_dependency $binfile libpthread\\.so] == 0 } {
>>      set libpthread_missing 1
>> }
> 
> The two has_dependency calls use $binfile.  Should one of them use
> $binfile_lib?  The second one I think.

Yes, thanks for catching this.

I'll commit after another build & test cycle.

Thanks,
- Tom