public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Pierre Muller <pierre.muller@ics-cnrs.unistra.fr>,
	       "'Sergio Durigan Junior'" <sergiodj@redhat.com>
Cc: "'GDB Patches'" <gdb-patches@sourceware.org>
Subject: Re: Build failure following: Implement support for checking /proc/PID/coredump_filter commit
Date: Wed, 08 Apr 2015 14:43:00 -0000	[thread overview]
Message-ID: <55253E9E.4060106@redhat.com> (raw)
In-Reply-To: <000001d07205$69de1770$3d9a4650$@muller@ics-cnrs.unistra.fr>

On 04/08/2015 03:07 PM, Pierre Muller wrote:

> Or maybe we should use the gnulib version of strtok_r?

Yes.

> I don't really know how to do this, but if someone can tell me,
> I can test the patch.

Let me give that a try, and I'll post a branch for you to test.

There's also the "users/palves/gnulib-update" branch that
updates gdb's copy of gnulib to recent gnulib master.  It'd
be great if someone confirmed that a gdb build of that branch
actually works on Windows, so we can move forward with that.
(the branch predates Sergio's patch, so isn't affected by the strtok_r
issue).  I'd be nice to update our gnulib copy before we pull in
more modules, to avoid tripping on bugs that have meanwhile already
been fixed upstream, or avoid module dependencies that may
have been reduced upstream...

Thanks,
Pedro Alves

  reply	other threads:[~2015-04-08 14:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-24 23:57 [PATCH v4 0/2] Improve corefile generation by using /proc/PID/coredump_filter (PR corefile/16902) Sergio Durigan Junior
2015-03-24 23:57 ` [PATCH 1/2] Implement support for checking /proc/PID/coredump_filter Sergio Durigan Junior
2015-03-27  9:53   ` Pedro Alves
2015-03-31 23:40     ` Sergio Durigan Junior
2015-04-08 14:08       ` Build failure following: Implement support for checking /proc/PID/coredump_filter commit Pierre Muller
2015-04-08 14:43         ` Pedro Alves [this message]
2015-04-08 15:14           ` Pedro Alves
2015-04-08 16:08             ` Sergio Durigan Junior
2015-04-08 16:28             ` Pierre Muller
2015-04-08 16:47               ` Sergio Durigan Junior
2015-04-08 17:21                 ` Pedro Alves
2015-04-08 16:27           ` Yao Qi
2015-04-08 16:47             ` Pedro Alves
2015-03-24 23:57 ` [PATCH 2/2] Documentation and testcase Sergio Durigan Junior
2015-03-27  9:53   ` Pedro Alves

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55253E9E.4060106@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pierre.muller@ics-cnrs.unistra.fr \
    --cc=sergiodj@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).