From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 87348 invoked by alias); 8 Apr 2015 14:43:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 87334 invoked by uid 89); 8 Apr 2015 14:43:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 08 Apr 2015 14:43:50 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t38EhjvK001403 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 8 Apr 2015 10:43:46 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t38EhgWS019865; Wed, 8 Apr 2015 10:43:44 -0400 Message-ID: <55253E9E.4060106@redhat.com> Date: Wed, 08 Apr 2015 14:43:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Pierre Muller , "'Sergio Durigan Junior'" CC: "'GDB Patches'" Subject: Re: Build failure following: Implement support for checking /proc/PID/coredump_filter commit References: <1427241443-5939-1-git-send-email-sergiodj@redhat.com> <1427241443-5939-2-git-send-email-sergiodj@redhat.com> <5515289D.1000006@redhat.com> <874mp0vir0.fsf@redhat.com> <000001d07205$69de1770$3d9a4650$@muller@ics-cnrs.unistra.fr> In-Reply-To: <000001d07205$69de1770$3d9a4650$@muller@ics-cnrs.unistra.fr> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00267.txt.bz2 On 04/08/2015 03:07 PM, Pierre Muller wrote: > Or maybe we should use the gnulib version of strtok_r? Yes. > I don't really know how to do this, but if someone can tell me, > I can test the patch. Let me give that a try, and I'll post a branch for you to test. There's also the "users/palves/gnulib-update" branch that updates gdb's copy of gnulib to recent gnulib master. It'd be great if someone confirmed that a gdb build of that branch actually works on Windows, so we can move forward with that. (the branch predates Sergio's patch, so isn't affected by the strtok_r issue). I'd be nice to update our gnulib copy before we pull in more modules, to avoid tripping on bugs that have meanwhile already been fixed upstream, or avoid module dependencies that may have been reduced upstream... Thanks, Pedro Alves