From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20453 invoked by alias); 13 Apr 2015 13:52:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20422 invoked by uid 89); 13 Apr 2015 13:52:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Apr 2015 13:51:59 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 586808E3CA; Mon, 13 Apr 2015 13:51:58 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3DDpue6016524; Mon, 13 Apr 2015 09:51:57 -0400 Message-ID: <552BC9FC.2020201@redhat.com> Date: Mon, 13 Apr 2015 13:52:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH 4/6] testsuite: Don't use expect_background to reap gdbserver References: <1424699660-11727-1-git-send-email-palves@redhat.com> <1424699660-11727-5-git-send-email-palves@redhat.com> <864mokuuep.fsf@gmail.com> <552BB206.4000803@redhat.com> <552BC3C2.6010103@gmail.com> In-Reply-To: <552BC3C2.6010103@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00457.txt.bz2 On 04/13/2015 02:25 PM, Yao Qi wrote: > On 13/04/15 13:09, Pedro Alves wrote: >>> I wrap the send_gdb and gdb_expect statement above by "catch", >>>> testing looks fine, although error messages are still shown in the >>>> console and gdb.log. >> Why not suppress the error message? I think you just need to pass >> a var name as second parameter to "catch". > > I did that, but it is useless. These messages prefixed with > "ERROR OCCURED:" are printed by DejaGNU, lib/remote.exp:remote_expect, > > if {$code == 1} { > if {[info exists string]} {send_user "ERROR OCCURED: $errorInfo > $errorCode $string"} > > looks we can't prevent DejaGNU invoking send_user. I think we should just call raw "expect" instead then. > If this error is > annoying, we can unset gdb_spawn_id at the end of proc do_test in > gdb-sigterm.exp. I think also need to call wait too? There are other eof calls in other tests too and also under lib/ We'd need to do the same to all of those, and then, at least, we'd need to make default_gdb_exit not skip the inotify_log_file code too. I'm not sure I like that direction. (BTW, that remote host code in default_gdb_exit looks like should be given the same treatment.) Thanks, Pedro Alves