From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102139 invoked by alias); 15 Apr 2015 15:37:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102121 invoked by uid 89); 15 Apr 2015 15:37:52 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 15 Apr 2015 15:37:51 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3FFbllk003824 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 15 Apr 2015 11:37:47 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3FFbjrl023552; Wed, 15 Apr 2015 11:37:46 -0400 Message-ID: <552E85C9.20501@redhat.com> Date: Wed, 15 Apr 2015 15:37:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Don Breazeal , gdb-patches@sourceware.org Subject: Re: [PATCH v7 1/7] Identify remote fork event support References: <1428685786-18094-1-git-send-email-donb@codesourcery.com> <1428685786-18094-2-git-send-email-donb@codesourcery.com> In-Reply-To: <1428685786-18094-2-git-send-email-donb@codesourcery.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00572.txt.bz2 On 04/10/2015 06:09 PM, Don Breazeal wrote: > @@ -6469,4 +6487,7 @@ initialize_low (void) > sigaction (SIGCHLD, &sigchld_action, NULL); > > initialize_low_arch (); > + > + /* Enable extended ptrace events. */ > + linux_check_ptrace_features (); I think the comment might have made sense possibly in a earlier revision that added to additional ptrace options, but it looks a bit strange now, as this isn't enabling the features yet, just checking what is supported. A comment like /* Check supported ptrace features. */ would just repeat the function's signature, so I'd suggest just dropping the comment. Otherwise OK. Thanks, Pedro Alves