From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21202 invoked by alias); 15 Apr 2015 16:09:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21188 invoked by uid 89); 15 Apr 2015 16:09:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 15 Apr 2015 16:09:27 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3FG9P9o011378 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 15 Apr 2015 12:09:25 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3FG9NZZ003083; Wed, 15 Apr 2015 12:09:24 -0400 Message-ID: <552E8D33.3050708@redhat.com> Date: Wed, 15 Apr 2015 16:09:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson , Eli Zaretskii CC: gdb-patches@sourceware.org Subject: Re: [PATCH 7/7] Access executable from remote system when first inferior appears References: <1427887341-31819-1-git-send-email-gbenson@redhat.com> <1427887341-31819-8-git-send-email-gbenson@redhat.com> <552E3C6B.2090300@redhat.com> <20150415135555.GA18079@blade.nx> In-Reply-To: <20150415135555.GA18079@blade.nx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00582.txt.bz2 On 04/15/2015 02:55 PM, Gary Benson wrote: > Pedro Alves wrote: >> On 04/01/2015 12:22 PM, Gary Benson wrote: >>> This commit modifies remote_add_inferior to take an extra argument >>> try_open_exec. If this is nonzero, remote_add_inferior will >>> attempt to open this inferior's executable as the main executable >>> if no main executable is open already. Callers are updated >>> appropriately. >>> >>> One testcase required updating as a result of this commit. The >>> test checked that GDB's "info files" command does not crash if no >>> main executable is open, and relied on GDB's inability to access >>> the main executable over the remote protocol. The test was >>> updated to inhibit this new behavior. >> >> So this is significant user-visible change too. I think it deserves >> an example in the commit log, and a NEWS entry. The manual should >> probably be updated to explain/mention this too. We already mention >> something like this in the "attach" docs: >> >> "When you use @code{attach}, the debugger finds the program running in >> the process first (...)" > > How about these? > > diff --git a/gdb/NEWS b/gdb/NEWS > index b11a6fc..e88210f 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -36,6 +36,11 @@ > the operating system) when starting processes remotely, and when > attaching to already-running local or remote processes. > > +* GDB now supports automatic location and retrieval of executable > + files from remote targets. Remote debugging can now be initiated > + using only a "target remote" or "target extended-remote" command > + (no "set sysroot" or "file" commands are required). LGTM, though it should probably say See "New remote packets" below/above. too, to hint that this needs remote target support. It's what we did in the range-stepping NEWS entry, for example. Thanks, Pedro Alves