From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>, Eli Zaretskii <eliz@gnu.org>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 7/7] Access executable from remote system when first inferior appears
Date: Wed, 15 Apr 2015 16:13:00 -0000 [thread overview]
Message-ID: <552E8E34.4030006@redhat.com> (raw)
In-Reply-To: <20150415135555.GA18079@blade.nx>
On 04/15/2015 02:55 PM, Gary Benson wrote:
> Pedro Alves wrote:
>> > On 04/01/2015 12:22 PM, Gary Benson wrote:
>>> > > This commit modifies remote_add_inferior to take an extra argument
>>> > > try_open_exec. If this is nonzero, remote_add_inferior will
>>> > > attempt to open this inferior's executable as the main executable
>>> > > if no main executable is open already. Callers are updated
>>> > > appropriately.
>>> > >
>>> > > One testcase required updating as a result of this commit. The
>>> > > test checked that GDB's "info files" command does not crash if no
>>> > > main executable is open, and relied on GDB's inability to access
>>> > > the main executable over the remote protocol. The test was
>>> > > updated to inhibit this new behavior.
>> >
>> > So this is significant user-visible change too. I think it deserves
>> > an example in the commit log, and a NEWS entry. The manual should
>> > probably be updated to explain/mention this too. We already mention
>> > something like this in the "attach" docs:
>> >
>> > "When you use @code{attach}, the debugger finds the program running in
>> > the process first (...)"
> How about these?
>
Missed the manual bit:
>
> ** gdb.Objfile objects have a new attribute "username",
> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index 964f9c4..4f9c21b 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -2531,7 +2531,8 @@ programs on bare-board targets that lack an operating system. You must
> also have permission to send the process a signal.
>
> When you use @code{attach}, the debugger finds the program running in
> -the process first by looking in the current working directory, then (if
> +the process first by querying the operating system. If this fails,
> +@value{GDBN} looks first in the current working directory, then (if
> the program is not found) by using the source file search path
> (@pxref{Source Path, ,Specifying Source Directories}). You can also use
> the @code{file} command to load the program. @xref{Files, ,Commands to
This looks right, but it's not what I was thinking. The "attach" reference
was just to give an example of where we document that gdb find the
program for the user. I think we should say something like that in
the "target remote" documentation too.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-04-15 16:13 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-01 11:22 [PATCH 0/7] Do not require "file" commands for remote targets Gary Benson
2015-04-01 11:22 ` [PATCH 1/7] Introduce exec_file_locate_attach Gary Benson
2015-04-01 11:22 ` [PATCH 3/7] Use gdb_sysroot for main executable on attach Gary Benson
2015-04-01 14:53 ` Eli Zaretskii
2015-04-15 12:45 ` Gary Benson
2015-04-15 10:43 ` Pedro Alves
2015-04-01 11:22 ` [PATCH 2/7] Introduce exec_file_find Gary Benson
2015-04-01 11:27 ` [PATCH 4/7] Introduce linux_pid_to_exec_file Gary Benson
2015-04-06 16:41 ` Doug Evans
2015-04-07 9:07 ` Gary Benson
2015-04-08 3:15 ` Doug Evans
2015-04-08 8:06 ` Gary Benson
2015-04-15 9:37 ` Pedro Alves
2015-04-15 13:14 ` [PATCH 4/7 v2] Introduce linux_proc_pid_to_exec_file Gary Benson
2015-04-15 16:01 ` Pedro Alves
2015-04-01 11:29 ` [PATCH 5/7] Implement remote_pid_to_exec_file using qXfer:exec-file:read Gary Benson
2015-04-01 14:55 ` Eli Zaretskii
2015-04-06 17:00 ` Doug Evans
2015-04-06 17:21 ` Eli Zaretskii
2015-04-06 21:57 ` Doug Evans
2015-04-07 6:09 ` Eli Zaretskii
2015-04-07 9:08 ` Gary Benson
2015-04-08 1:57 ` Doug Evans
2015-04-08 6:00 ` Eli Zaretskii
2015-04-01 11:30 ` [PATCH 6/7] Implement qXfer:exec-file:read in gdbserver Gary Benson
2015-04-06 17:11 ` Doug Evans
2015-04-07 9:19 ` Gary Benson
2015-04-17 23:43 ` Possible regression on gdb.base/attach.exp when using native-extended-gdbserver (was: Re: [PATCH 6/7] Implement qXfer:exec-file:read in gdbserver) Sergio Durigan Junior
2015-04-20 9:13 ` Gary Benson
2015-04-20 10:41 ` [OB PATCH] Fix three test failures with extended remote targets Gary Benson
2015-04-01 11:39 ` [PATCH 7/7] Access executable from remote system when first inferior appears Gary Benson
2015-04-15 10:24 ` Pedro Alves
2015-04-15 13:56 ` Gary Benson
2015-04-15 14:06 ` Gary Benson
2015-04-15 16:15 ` Pedro Alves
2015-04-15 16:09 ` Pedro Alves
2015-04-16 8:23 ` Gary Benson
2015-04-15 16:13 ` Pedro Alves [this message]
2015-04-16 9:30 ` Gary Benson
2015-04-16 9:53 ` Pedro Alves
2015-04-16 11:47 ` Gary Benson
2015-04-16 15:06 ` Eli Zaretskii
2015-04-16 15:23 ` Pedro Alves
2015-04-16 15:05 ` Eli Zaretskii
2015-04-16 19:34 ` Gary Benson
2015-04-15 16:21 ` Eli Zaretskii
2015-04-15 10:47 ` [PATCH 0/7] Do not require "file" commands for remote targets Pedro Alves
2015-04-15 12:02 ` Gary Benson
2015-04-15 12:16 ` Pedro Alves
2015-04-15 14:16 ` Gary Benson
2015-04-15 16:20 ` Pedro Alves
2015-04-17 9:01 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=552E8E34.4030006@redhat.com \
--to=palves@redhat.com \
--cc=eliz@gnu.org \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).