Re: [PATCH] Make addrmap const-correct in cooked index

[Simon Marchi <simark@simark.ca>]

On 1/27/23 16:20, Simon Marchi via Gdb-patches wrote:
> 
> 
> On 1/27/23 16:18, Tom Tromey wrote:
>>>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:
>>
>> Simon> -void *
>> Simon> +const void *
>> Simon>  addrmap_fixed::find (CORE_ADDR addr) const
>> Simon>  {
>> Simon>    const struct addrmap_transition *bottom = &transitions[0];
>>
>> Actually, this is going to rely on casting away const in some spots.
>>
>> For example cooked_index::lookup:
>>
>>   dwarf2_per_cu_data *lookup (CORE_ADDR addr) const
>>   {
>>     return (dwarf2_per_cu_data *) m_addrmap->find (addr);
>>   }
>>
>> Probably we can't constify dwarf2_per_cu_data all over.
> 
> I suppose in this case we can consider that it's the DWARF code that is
> broken, and that it knows the risks of casting away the const.  But at
> least the addrmap code will be correct.

Or, if the client code legitimately wants to modify the contained
objects, then we provide a non-const version of addrmap::find that
returns a non-const pointer.

Simon