From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 131001 invoked by alias); 17 Apr 2015 17:46:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 130983 invoked by uid 89); 17 Apr 2015 17:46:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 17 Apr 2015 17:46:19 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3HHkGLW013513 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 17 Apr 2015 13:46:17 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3HHkFTj003644; Fri, 17 Apr 2015 13:46:15 -0400 Message-ID: <553146E6.8050003@redhat.com> Date: Fri, 17 Apr 2015 17:46:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Doug Evans CC: Gary Benson , gdb-patches Subject: Re: [PATCH 2/7] Introduce target_fileio_set_fs References: <1429186791-6867-1-git-send-email-gbenson@redhat.com> <1429186791-6867-3-git-send-email-gbenson@redhat.com> <20150417133628.GA26681@blade.nx> <553116EB.6050508@redhat.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00701.txt.bz2 On 04/17/2015 06:28 PM, Doug Evans wrote: > On Fri, Apr 17, 2015 at 7:21 AM, Pedro Alves wrote: >> On 04/17/2015 02:36 PM, Gary Benson wrote: >> >>> It was basically because the alternative was to add a parameter to >>> target_filesystem_is_local and target_fileio_{open,readlink,unlink} >>> (and all their target vector implementations) to pass around whatever >>> inferior you were talking about. You'd also have to make a lot more >>> changes to the remote protocol: either vFile:{open,unlink,readlink} >>> would need an extra argument (indicated with qSupported) or you'd need >>> new "fs" versions of each packet. Both Pedro and I thought that was >>> ugly. >> >> Right, this way mirrors what's done at the posix/system call level too, >> and if some other systems needs something different for selecting >> a "filesystem namespace", there's a single method/packet to change. > > Fair enough. > All I would ask is that this get pushed down as far as possible in the > call stack. > > E.g., while I wouldn't suggest massive changes to the remote protocol > (regardless of how desperately IWBN), IWBN that layers above that > follow good programming practices (avoiding using global state > wherever possible/reasonable). Fair enough as well. I'm fine with adding explicit arguments on the layers above, leaving the packet as is. Thanks, Pedro Alves