From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122818 invoked by alias); 20 Apr 2015 12:14:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122809 invoked by uid 89); 20 Apr 2015 12:14:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: usevmg21.ericsson.net Received: from usevmg21.ericsson.net (HELO usevmg21.ericsson.net) (198.24.6.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 20 Apr 2015 12:14:14 +0000 Received: from EUSAAHC003.ericsson.se (Unknown_Domain [147.117.188.81]) by usevmg21.ericsson.net (Symantec Mail Security) with SMTP id 4A.4C.17241.E4A84355; Mon, 20 Apr 2015 07:10:38 +0200 (CEST) Received: from [142.133.110.95] (147.117.188.8) by smtp-am.internal.ericsson.com (147.117.188.83) with Microsoft SMTP Server id 14.3.210.2; Mon, 20 Apr 2015 08:14:10 -0400 Message-ID: <5534ED92.1010604@ericsson.com> Date: Mon, 20 Apr 2015 12:14:00 -0000 From: Antoine Tremblay User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Subject: Re: [PATCH] Fix MI dprintf-insert not printing when a location is pending. References: <55154E63.5040603@ericsson.com> <1427459819-29661-1-git-send-email-antoine.tremblay@ericsson.com> <55158AAF.7010709@redhat.com> <55158F97.7030400@ericsson.com> <55159493.20005@redhat.com> In-Reply-To: <55159493.20005@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-04/txt/msg00742.txt.bz2 ping... On 03/27/2015 01:34 PM, Keith Seitz wrote: > On 03/27/2015 10:12 AM, Antoine Tremblay wrote: >> However there is still a problem forcing me to use gdb_expect I think, >> namely mi_gdb_test waits for a command prompt like so : >> >> -re "^($string_regex\[\r\n\]+)?($pattern\[\r\n\]+$mi_gdb_prompt\[ \]*)" >> >> However dprintf does mean you will get a prompt printed... >> >> You will get a prompt only when hitting the breakpoint I placed. > > Ick. Yeah, you are right. My bad. > >> I could remove mi_expect_stop at the end and assume that breakpoint will >> not fail but I think it's not right ? also mi-dprintf.exp is using the >> same mi_run_cmd / gdb_expect / mi_expect_stop ... >> >> What do you think ? > > I think everything is fine as it is. Sorry about the noise. > > So, once again, while I am not a maintainer, I recommend a maintainer > approve this patch. > > Thank you for your patience, > Keith >