From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 109592 invoked by alias); 22 Apr 2015 20:03:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 109581 invoked by uid 89); 22 Apr 2015 20:03:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 22 Apr 2015 20:03:38 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3MK3a5W006384 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 22 Apr 2015 16:03:36 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3MK3YFu012952; Wed, 22 Apr 2015 16:03:35 -0400 Message-ID: <5537FE96.1090706@redhat.com> Date: Wed, 22 Apr 2015 20:03:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Yao Qi CC: gdb-patches@sourceware.org Subject: Re: [PATCH v3 12/17] Fix interrupt-noterm.exp on targets always in non-stop References: <1429267521-21047-1-git-send-email-palves@redhat.com> <1429267521-21047-13-git-send-email-palves@redhat.com> <86y4llyajb.fsf@gmail.com> In-Reply-To: <86y4llyajb.fsf@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00841.txt.bz2 On 04/21/2015 12:40 PM, Yao Qi wrote: > Pedro Alves writes: > >> Most of the patch is an across-the-board rename of to_stop hook >> implementations to to_interrupt. The only targets where something > > except on gnu-nat.c, Ah, yes. > >> more than a rename is being done are linux-nat.c and remote.c, which >> are the only targets that support async, and thus are the only ones >> the core side calls target_stop on. >> >> gdb/ChangeLog: >> 2015-04-17 Pedro Alves >> >> * darwin-nat.c (darwin_stop): Rename to ... >> (darwin_interrupt): ... this. >> (_initialize_darwin_inferior): Adjust. >> * gnu-nat.c (gnu_stop): Delete. >> (gnu_thread_alive): Don't install gnu_stop. > ^^^^^^^^^^^^^^^^^ gnu_target Whoops, fixed. > >> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c >> index d830773..4753634 100644 >> --- a/gdb/gnu-nat.c >> +++ b/gdb/gnu-nat.c >> @@ -2271,12 +2271,6 @@ gnu_terminal_init (struct target_ops *self) >> child_terminal_init_with_pgrp (gnu_current_inf->pid); >> } >> >> -static void >> -gnu_stop (struct target_ops *self, ptid_t ptid) >> -{ >> - error (_("to_stop target function not implemented")); >> -} >> - >> static int >> gnu_thread_alive (struct target_ops *ops, ptid_t ptid) >> { >> @@ -2686,7 +2680,6 @@ gnu_target (void) >> t->to_mourn_inferior = gnu_mourn_inferior; >> t->to_thread_alive = gnu_thread_alive; >> t->to_pid_to_str = gnu_pid_to_str; >> - t->to_stop = gnu_stop; >> >> return t; >> } > > Any reason you don't install to_interrupt for gnu-nat? I'll sent the gnu-nat change as a separate patch, along with the rationale. -- Pedro Alves