From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81533 invoked by alias); 27 Apr 2015 16:05:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81512 invoked by uid 89); 27 Apr 2015 16:05:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 27 Apr 2015 16:05:01 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3RG4wXp016124 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 27 Apr 2015 12:04:58 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3RG4vch028445; Mon, 27 Apr 2015 12:04:57 -0400 Message-ID: <553E5E28.60208@redhat.com> Date: Mon, 27 Apr 2015 16:05:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Patrick Palka , gdb-patches@sourceware.org Subject: Re: [PATCH] Make type-safe the 'content' field of struct tui_gen_win_info References: <1429880136-5830-1-git-send-email-patrick@parcs.ath.cx> In-Reply-To: <1429880136-5830-1-git-send-email-patrick@parcs.ath.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg00998.txt.bz2 On 04/24/2015 01:55 PM, Patrick Palka wrote: > The 'content' field of struct tui_gen_win_info currently has type > void ** but the field always stores an object of type tui_win_content. > Instead of unnecessarily casting to and from void ** we should just give > the field the type tui_win_content in the first place. > > This patch does this and also eliminates all now-redundant casts > involving the 'content' struct field that I could find. > OK. Thanks, Pedro Alves