From: Pedro Alves <palves@redhat.com>
To: Gabriel Krisman Bertazi <gabriel@krisman.be>, gdb-patches@sourceware.org
Cc: dje@google.com, sergiodj@redhat.com
Subject: Re: [PATCH v3 00/17] Catch syscall group
Date: Tue, 28 Apr 2015 11:24:00 -0000 [thread overview]
Message-ID: <553F6BC0.9000905@redhat.com> (raw)
In-Reply-To: <1430011521-24340-1-git-send-email-gabriel@krisman.be>
On 04/26/2015 02:25 AM, Gabriel Krisman Bertazi wrote:
> Hello,
>
> This is the third version of the catch syscall group patches. This
> version presents the following modifications, other than fixing the
> things Sergio and Doug pointed out in previous reviews:
>
> * Created syscall groups for every architecture supported by catch
> syscall.
>
> The previous version only implemented syscalls for amd64. I used a
> script to generate the xmls, and based the group field information on
> strace, so please share your thoughts if you disagree with any group.
Thanks.
OOC, does strace also maintain a separate group table per architecture?
Was your script something like a map of syscall _name_ to group?
I was wondering if we couldn't share most of the grouping
per-architecture, e.g., by having each arch syscall file xi:include a
base Linux default groups file, that listed the grouping without
the syscall number. E.g., create a linux-defaults.xml like:
<syscall-defaults name="select" groups="descriptor"/>
...
<syscall-defaults name="openat" groups="descriptor,file"/>
And then the arch-specific syscall files would do:
<xi:include href="linux-defaults.xml"/>
...
<syscall name="select" number="82"/>
...
<syscall name="arch_specific_foo" number="200" groups="descriptor"/>
...
And then we teach gdb about syscall-default-groups, or
we could even instead preprocess the architecture xml to expand
the groups into each syscall with xsltproc (we already use
this tool, see gdb/features/Makefile and gdb/features/number-regs.xsl).
>
> I babysitted the xml generation scripts but I was not able to actually
> test them on architectures other than amd64 and i386. It would be very
> nice if someone could actually run catch-syscall.exp on other
> architectures.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-04-28 11:15 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-26 1:25 Gabriel Krisman Bertazi
2015-04-26 1:25 ` [PATCH v3 02/17] Add support to catch groups of syscalls Gabriel Krisman Bertazi
2015-04-26 1:25 ` [PATCH v3 03/17] Add tests for catching groups of syscalls on supported architectures Gabriel Krisman Bertazi
2015-04-26 18:44 ` Sergio Durigan Junior
2015-04-26 1:25 ` [PATCH v3 01/17] Implemement support for groups of syscalls in the xml-syscall interface Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 05/17] Create syscall groups for ppc Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 04/17] Create syscall groups for amd64 Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 09/17] Create syscall groups for bfin Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 12/17] Create syscall groups for mips-n64 Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 08/17] Create syscall groups for arm Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 10/17] Create syscall groups for i386 Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 06/17] Create syscall groups for ppc64 Gabriel Krisman Bertazi
2015-04-26 1:26 ` [PATCH v3 07/17] Create syscall groups for aarch64 Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 13/17] Create syscall groups for mips-o32 Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 14/17] Create syscall groups for s390 Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 11/17] Create syscall groups for mips-n32 Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 15/17] Create syscall groups for s390x Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 16/17] Create syscall groups for sparc Gabriel Krisman Bertazi
2015-04-26 1:47 ` [PATCH v3 17/17] Create syscall groups for sparc64 Gabriel Krisman Bertazi
2015-04-26 18:58 ` [PATCH v3 00/17] Catch syscall group Sergio Durigan Junior
2015-04-28 11:24 ` Pedro Alves [this message]
2015-04-29 0:45 ` Sergio Durigan Junior
2015-04-29 10:44 ` Pedro Alves
2015-05-04 2:34 ` Gabriel Krisman Bertazi
2015-05-06 14:38 ` Pedro Alves
2015-05-10 18:34 ` Gabriel Krisman Bertazi
2015-05-10 19:01 ` Sergio Durigan Junior
2015-05-11 0:28 ` [PATCH v4 0/4] catch " Gabriel Krisman Bertazi
2015-05-11 0:28 ` [PATCH v4 2/5] Add support to catch groups of syscalls Gabriel Krisman Bertazi
2015-05-13 10:38 ` Pedro Alves
2015-05-11 0:28 ` [PATCH v4 1/5] Implemement support for groups of syscalls in the xml-syscall interface Gabriel Krisman Bertazi
2015-05-11 0:28 ` [PATCH v4 5/5] Update documentation on catching a group of related syscalls Gabriel Krisman Bertazi
2015-05-11 0:40 ` Gabriel Krisman Bertazi
2015-05-13 10:30 ` Pedro Alves
2015-05-13 16:40 ` Eli Zaretskii
2015-05-11 0:28 ` [PATCH v4 3/5] Add tests for catching groups of syscalls on supported architectures Gabriel Krisman Bertazi
2015-05-11 0:28 ` [PATCH v4 4/5] Include group information in xml syscall files Gabriel Krisman Bertazi
2015-05-12 21:42 ` Doug Evans
2015-05-13 1:17 ` Gabriel Krisman Bertazi
2015-05-13 10:43 ` Pedro Alves
2015-05-13 10:47 ` [PATCH v4 0/4] catch syscall group Pedro Alves
2015-05-11 11:39 ` [PATCH v3 00/17] Catch " Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553F6BC0.9000905@redhat.com \
--to=palves@redhat.com \
--cc=dje@google.com \
--cc=gabriel@krisman.be \
--cc=gdb-patches@sourceware.org \
--cc=sergiodj@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).