From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 113363 invoked by alias); 28 Apr 2015 11:15:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 113346 invoked by uid 89); 28 Apr 2015 11:15:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Apr 2015 11:15:20 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3SBFFwn012860 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 28 Apr 2015 07:15:15 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3SBFDro016428; Tue, 28 Apr 2015 07:15:13 -0400 Message-ID: <553F6BC0.9000905@redhat.com> Date: Tue, 28 Apr 2015 11:24:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gabriel Krisman Bertazi , gdb-patches@sourceware.org CC: dje@google.com, sergiodj@redhat.com Subject: Re: [PATCH v3 00/17] Catch syscall group References: <1430011521-24340-1-git-send-email-gabriel@krisman.be> In-Reply-To: <1430011521-24340-1-git-send-email-gabriel@krisman.be> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg01034.txt.bz2 On 04/26/2015 02:25 AM, Gabriel Krisman Bertazi wrote: > Hello, > > This is the third version of the catch syscall group patches. This > version presents the following modifications, other than fixing the > things Sergio and Doug pointed out in previous reviews: > > * Created syscall groups for every architecture supported by catch > syscall. > > The previous version only implemented syscalls for amd64. I used a > script to generate the xmls, and based the group field information on > strace, so please share your thoughts if you disagree with any group. Thanks. OOC, does strace also maintain a separate group table per architecture? Was your script something like a map of syscall _name_ to group? I was wondering if we couldn't share most of the grouping per-architecture, e.g., by having each arch syscall file xi:include a base Linux default groups file, that listed the grouping without the syscall number. E.g., create a linux-defaults.xml like: ... And then the arch-specific syscall files would do: ... ... ... And then we teach gdb about syscall-default-groups, or we could even instead preprocess the architecture xml to expand the groups into each syscall with xsltproc (we already use this tool, see gdb/features/Makefile and gdb/features/number-regs.xsl). > > I babysitted the xml generation scripts but I was not able to actually > test them on architectures other than amd64 and i386. It would be very > nice if someone could actually run catch-syscall.exp on other > architectures. Thanks, Pedro Alves