From: Pedro Alves <palves@redhat.com>
To: Gary Benson <gbenson@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Use exec_file_find to prepend gdb_sysroot in follow_exec
Date: Tue, 28 Apr 2015 11:56:00 -0000 [thread overview]
Message-ID: <553F6F79.8000505@redhat.com> (raw)
In-Reply-To: <20150428112912.GA17957@blade.nx>
On 04/28/2015 12:29 PM, Gary Benson wrote:
> Pedro Alves wrote:
>> We now have at least two places that need to remember to call close.
>> IWBN if we hid that close in a exec_file_find variant, so that
>> callers didn't have to recall to do it. Maybe rename exec_file_find
>> to (e.g.) exec_file_find_fd and reuse the exec_file_find name, even.
>
> Good shout. How about I fix solib_find_1 to accept fd == NULL, and
> put the closing logic in there? That
Sounds good.
> would work for solib_find too then (I'm not sure if there are
> any "solib_find; close" places in GDB but I'll look.)
Thanks,
Pedro Alves
next prev parent reply other threads:[~2015-04-28 11:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 13:28 Gary Benson
2015-04-27 10:38 ` [PING][PATCH] " Gary Benson
2015-04-27 15:59 ` [PATCH] " Pedro Alves
2015-04-28 11:35 ` Gary Benson
2015-04-28 11:56 ` Pedro Alves [this message]
2015-04-28 21:50 ` [PATCH] Allow passing fd == NULL to exec_file_find and solib_find Gary Benson
2015-04-29 11:22 ` Pedro Alves
2015-04-29 15:24 ` Gary Benson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553F6F79.8000505@redhat.com \
--to=palves@redhat.com \
--cc=gbenson@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).