From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122251 invoked by alias); 28 Apr 2015 11:31:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 120101 invoked by uid 89); 28 Apr 2015 11:31:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 28 Apr 2015 11:31:09 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id t3SBV72K022065 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Tue, 28 Apr 2015 07:31:07 -0400 Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t3SBV5Hi018870; Tue, 28 Apr 2015 07:31:06 -0400 Message-ID: <553F6F79.8000505@redhat.com> Date: Tue, 28 Apr 2015 11:56:00 -0000 From: Pedro Alves User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Gary Benson CC: gdb-patches@sourceware.org Subject: Re: [PATCH] Use exec_file_find to prepend gdb_sysroot in follow_exec References: <1429277318-26646-1-git-send-email-gbenson@redhat.com> <553E5CF7.7090309@redhat.com> <20150428112912.GA17957@blade.nx> In-Reply-To: <20150428112912.GA17957@blade.nx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-04/txt/msg01038.txt.bz2 On 04/28/2015 12:29 PM, Gary Benson wrote: > Pedro Alves wrote: >> We now have at least two places that need to remember to call close. >> IWBN if we hid that close in a exec_file_find variant, so that >> callers didn't have to recall to do it. Maybe rename exec_file_find >> to (e.g.) exec_file_find_fd and reuse the exec_file_find name, even. > > Good shout. How about I fix solib_find_1 to accept fd == NULL, and > put the closing logic in there? That Sounds good. > would work for solib_find too then (I'm not sure if there are > any "solib_find; close" places in GDB but I'll look.) Thanks, Pedro Alves