[PATCH] Skip watch_thread_num.exp on targets without access watchpoints

[PATCH] Skip watch_thread_num.exp on targets without access watchpoints

[Andreas Arnez]

Since watch_thread_num.exp was changed to use access watchpoints, the
test case fails on s390 and s390x, since those targets do not support
access watchpoints.  This patch skips the test case on such targets.

gdb/testsuite/ChangeLog:

	* gdb.base/watch_thread_num.exp: Skip test on targets without
	access watchpoints.
---
 gdb/testsuite/gdb.base/watch_thread_num.exp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.base/watch_thread_num.exp b/gdb/testsuite/gdb.base/watch_thread_num.exp
index d559f22..6d767c2 100644
--- a/gdb/testsuite/gdb.base/watch_thread_num.exp
+++ b/gdb/testsuite/gdb.base/watch_thread_num.exp
@@ -21,7 +21,9 @@
 
 # This test verifies that a watchpoint is detected in the proper thread
 # so the test is only meaningful on a system with hardware watchpoints.
-if {[skip_hw_watchpoint_tests]} {
+# More specifically, the implementation of this test uses access
+# watchpoints, so skip it when those are not available.
+if {[skip_hw_watchpoint_access_tests]} {
     return 0
 }
 
-- 
1.9.3

Re: [PATCH] Skip watch_thread_num.exp on targets without access watchpoints

[Pedro Alves]

On 04/28/2015 12:35 PM, Andreas Arnez wrote:
> Since watch_thread_num.exp was changed to use access watchpoints, the
> test case fails on s390 and s390x, since those targets do not support
> access watchpoints.  This patch skips the test case on such targets.
> 
> gdb/testsuite/ChangeLog:
> 
> 	* gdb.base/watch_thread_num.exp: Skip test on targets without
> 	access watchpoints.

OK.

Thanks,
Pedro Alves